Skip to content

Fix CSharpReplIdeFeatures failing integration tests #80363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 19, 2025
Merged

Fix CSharpReplIdeFeatures failing integration tests #80363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b252a8
add timeout when getting controldatasource
akhera99 Sep 18, 2025
acf8f04
fix
akhera99 Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/VisualStudio/IntegrationTest/New.IntegrationTests/CSharp/CSharpReplIdeFeatures.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ public async Task HighlightRefsSingleSubmissionVerifyRenameTagsGoAway()
}

[IdeFact]
public async Task HighlightRefsMultipleSubmisionsVerifyRenameTagsShowUpWhenInvokedOnSubmittedText()
public async Task HighlightRefsMultipleSubmissionsVerifyRenameTagsShowUpWhenInvokedOnSubmittedText()
{
await TestServices.InteractiveWindow.SubmitTextAsync("class Goo { }", HangMitigatingCancellationToken);
await TestServices.InteractiveWindow.SubmitTextAsync("Goo something = new Goo();", HangMitigatingCancellationToken);
Expand All @@ -97,7 +97,7 @@ public async Task HighlightRefsMultipleSubmisionsVerifyRenameTagsShowUpWhenInvok
}

[IdeFact]
public async Task HighlightRefsMultipleSubmisionsVerifyRenameTagsShowUpOnUnsubmittedText()
public async Task HighlightRefsMultipleSubmissionsVerifyRenameTagsShowUpOnUnsubmittedText()
{
await TestServices.InteractiveWindow.SubmitTextAsync("class Goo { }", HangMitigatingCancellationToken);
await TestServices.InteractiveWindow.SubmitTextAsync("Goo something = new Goo();", HangMitigatingCancellationToken);
Expand All @@ -109,7 +109,7 @@ public async Task HighlightRefsMultipleSubmisionsVerifyRenameTagsShowUpOnUnsubmi
}

[IdeFact]
public async Task HighlightRefsMultipleSubmisionsVerifyRenameTagsShowUpOnTypesWhenInvokedOnSubmittedText()
public async Task HighlightRefsMultipleSubmissionsVerifyRenameTagsShowUpOnTypesWhenInvokedOnSubmittedText()
{
await TestServices.InteractiveWindow.SubmitTextAsync("class Goo { }", HangMitigatingCancellationToken);
await TestServices.InteractiveWindow.SubmitTextAsync("Goo a;", HangMitigatingCancellationToken);
Expand All @@ -121,7 +121,7 @@ public async Task HighlightRefsMultipleSubmisionsVerifyRenameTagsShowUpOnTypesWh
}

[IdeFact]
public async Task HighlightRefsMultipleSubmisionsVerifyRenameTagsShowUpOnTypesWhenInvokedOnUnsubmittedText()
public async Task HighlightRefsMultipleSubmissionsVerifyRenameTagsShowUpOnTypesWhenInvokedOnUnsubmittedText()
{
await TestServices.InteractiveWindow.SubmitTextAsync("class Goo { }", HangMitigatingCancellationToken);
await TestServices.InteractiveWindow.SubmitTextAsync("Goo a;", HangMitigatingCancellationToken);
Expand All @@ -133,7 +133,7 @@ public async Task HighlightRefsMultipleSubmisionsVerifyRenameTagsShowUpOnTypesWh
}

[IdeFact]
public async Task HighlightRefsMultipleSubmisionsVerifyRenameTagsGoAwayWhenInvokedOnUnsubmittedText()
public async Task HighlightRefsMultipleSubmissionsVerifyRenameTagsGoAwayWhenInvokedOnUnsubmittedText()
{
await TestServices.InteractiveWindow.SubmitTextAsync("class Goo { }", HangMitigatingCancellationToken);
await TestServices.InteractiveWindow.SubmitTextAsync("Goo a;", HangMitigatingCancellationToken);
Expand All @@ -145,7 +145,7 @@ public async Task HighlightRefsMultipleSubmisionsVerifyRenameTagsGoAwayWhenInvok
}

[IdeFact]
public async Task HighlightRefsMultipleSubmisionsVerifyRenameTagsOnRedefinedVariable()
public async Task HighlightRefsMultipleSubmissionsVerifyRenameTagsOnRedefinedVariable()
{
await TestServices.InteractiveWindow.SubmitTextAsync("string abc = null;", HangMitigatingCancellationToken);
await TestServices.InteractiveWindow.SubmitTextAsync("abc = string.Empty;", HangMitigatingCancellationToken);
Expand Down
3 changes: 2 additions & 1 deletion src/VisualStudio/IntegrationTest/New.IntegrationTests/InProcess/ShellInProcess.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
using Microsoft.VisualStudio.Shell;
using Microsoft.VisualStudio.Shell.Interop;
using Microsoft.VisualStudio.Threading;
using Roslyn.Test.Utilities;
using Xunit;
using IAsyncDisposable = System.IAsyncDisposable;

Expand Down Expand Up @@ -100,7 +101,7 @@ private async Task ExecuteRemotableCommandAsync(string commandName, Cancellation
ErrorHandler.ThrowOnFailure(commandService.GetControlDataSourceAsync(
(uint)__VSCOMMANDTYPES.cCommandTypeButton,
commandName,
timeout: 0,
timeout: ((int)TestHelpers.HangMitigatingTimeout.TotalMilliseconds),
out var dataSourceTask));

Assumes.NotNull(dataSourceTask);
Expand Down
Loading