Skip to content

Support field keyword in EE. #80515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 4, 2025
Merged

Support field keyword in EE. #80515

merged 3 commits into from
Oct 4, 2025

Conversation

@AlekseyTs
Copy link
Contributor

Fixes #80442.

@AlekseyTs AlekseyTs requested a review from a team as a code owner September 30, 2025 17:59
@jjonescz jjonescz changed the title Support feild keyword in EE. Support field keyword in EE. Sep 30, 2025
@RikkiGibson RikkiGibson self-assigned this Sep 30, 2025
@AlekseyTs
Copy link
Contributor Author

@RikkiGibson, @333fred, @dotnet/roslyn-compiler Please review

333fred
333fred reviewed Oct 1, 2025
View reviewed changes
src/ExpressionEvaluator/CSharp/Test/ExpressionCompiler/HoistedThisTests.cs Outdated
var moveNextMethod = stateMachineType.GetMember<MethodSymbol>("MoveNext");

var guessedIterator = CompilationContext.GetSubstitutedSourceMethod(new EECompilationContextMethod(comp2, moveNextMethod), sourceMethodMustBeInstance: true);
var guessedIterator = new CompilationContext(comp2, moveNextMethod, moveNextMethod, [], [], MethodDebugInfo<TypeSymbol, LocalSymbol>.None).
Copy link
Member

@333fred 333fred Oct 1, 2025 •
edited by AlekseyTs
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding parameter names for readability. #Resolved

@AlekseyTs AlekseyTs requested a review from a team October 2, 2025 13:12
@AlekseyTs
Copy link
Contributor Author

@RikkiGibson, @dotnet/roslyn-compiler For a second review

@AlekseyTs
Copy link
Contributor Author

@RikkiGibson, @dotnet/roslyn-compiler For a second review

@RikkiGibson
Copy link
Member

Taking a look this afternoon

@AlekseyTs AlekseyTs enabled auto-merge (squash) October 4, 2025 14:47
@AlekseyTs AlekseyTs merged commit b02727d into dotnet:main Oct 4, 2025
27 of 28 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Oct 4, 2025
333fred added a commit to 333fred/roslyn that referenced this pull request Oct 6, 2025
@333fred
Merge remote-tracking branch 'upstream/main' into await-apis
fc07a2a 
* upstream/main:
  Extensions: Close some tracked follow-ups (dotnet#80527)
  Fix outdated 17.15 to 18.0 (dotnet#80570)
  Update dependencies from https://github.com/dotnet/dotnet build 285582 (dotnet#80551)
  Fix all-in-one tests
  [main] Update dependencies from dotnet/arcade (dotnet#80559)
  Improve error recovery when object initializer uses ':' instead of '=' (dotnet#80553)
  Support `field` keyword in EE. (dotnet#80515)
  Log a debug message for ContentModified exceptions. (dotnet#80549)
  Update dependencies from https://github.com/dotnet/arcade build 20251002.2 (dotnet#80550)
333fred added a commit to 333fred/roslyn that referenced this pull request Oct 7, 2025
@333fred
Merge remote-tracking branch 'upstream/main' into test-runtime-async
6b3acd0 
* upstream/main: (252 commits)
  Move Watch EA to a separate assembly Microsoft.CodeAnalysis.ExternalAccess.HotReload (dotnet#80556)
  Enable long paths for Windows DartLab CI (dotnet#80581)
  Ensure that CS8659 is reported on partial properties (dotnet#80573)
  Fix a wrong relative link in a doc (dotnet#80567)
  [main] Source code updates from dotnet/dotnet (dotnet#80578)
  Update dependencies from https://github.com/dotnet/arcade build 20251006.2 (dotnet#80577)
  Update main configs after VS snap (dotnet#80523)
  Add followup async public apis (dotnet#80455)
  Reduce allocations in CSharpSyntaxNode.GetStructure (dotnet#80562)
  Extensions: Close some tracked follow-ups (dotnet#80527)
  Fix outdated 17.15 to 18.0 (dotnet#80570)
  Update dependencies from https://github.com/dotnet/dotnet build 285582 (dotnet#80551)
  Fix all-in-one tests
  [main] Update dependencies from dotnet/arcade (dotnet#80559)
  Improve error recovery when object initializer uses ':' instead of '=' (dotnet#80553)
  Support `field` keyword in EE. (dotnet#80515)
  Log a debug message for ContentModified exceptions. (dotnet#80549)
  Update dependencies from https://github.com/dotnet/arcade build 20251002.2 (dotnet#80550)
  Fix
  Simplify and add additional asserts
  ...
This was referenced Oct 8, 2025
Closed
Closed
qvalda pushed a commit to JetBrains/roslyn that referenced this pull request Oct 21, 2025
Jet Patch: v5.0.25_7463b6_VS_2
1191217 
cherry pick roslyn fixb02727d6c002cae550b4429e8e18101a7821a3fd
Support `field` keyword in EE. (dotnet#80515)

Fixes dotnet#80442.
(cherry picked from commit b02727d)

# Conflicts:
#	src/ExpressionEvaluator/CSharp/Source/ExpressionCompiler/EvaluationContext.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@333fred 333fred 333fred approved these changes

@RikkiGibson RikkiGibson RikkiGibson approved these changes

Assignees

@RikkiGibson RikkiGibson

Labels

Area-Compilers Feature - Field Keyword

Projects

None yet

Milestone

Next

Development

Successfully merging this pull request may close these issues.

EE: "field" keyword fails to be evaluated

3 participants

@AlekseyTs @RikkiGibson @333fred