Skip to content

Add regression test for compiler crash with syntax error in indexer declaration #80772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 23, 2025
Merged

Add regression test for compiler crash with syntax error in indexer declaration #80772

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
900927b
Initial plan
Copilot Oct 16, 2025
00a25ba
Add regression test for compiler crash with syntax error in indexer d…
Copilot Oct 16, 2025
c7d9949
Update src/Compilers/CSharp/Test/Symbol/Symbols/IndexerTests.cs
CyrusNajmabadi Oct 16, 2025
74c8595
Update src/Compilers/CSharp/Test/Symbol/Symbols/IndexerTests.cs
CyrusNajmabadi Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 51 additions & 0 deletions src/Compilers/CSharp/Test/Symbol/Symbols/IndexerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2968,5 +2968,56 @@ public struct A
// public A(int x, A a = new A()[1]) { }
Diagnostic(ErrorCode.ERR_DefaultValueMustBeConstant, "new A()[1]").WithArguments("a").WithLocation(8, 27));
}

[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/43145")]
public void CompilerShouldNotCrashOnSyntaxErrorInIndexerDeclaration()
{
var source =
"""
struct S
{
public bool This[int t] { get { return false; } }
}
""";
var compilation = CreateCompilation(source, options: TestOptions.DebugDll);
compilation.GetDiagnostics();
compilation.VerifyDiagnostics(
// (3,17): warning CS0649: Field 'S.This' is never assigned to, and will always have its default value false
// public bool This[int t] { get { return false; } }
Diagnostic(ErrorCode.WRN_UnassignedInternalField, "This").WithArguments("S.This", "false").WithLocation(3, 17),
// (3,21): error CS0650: Bad array declarator: To declare a managed array the rank specifier precedes the variable's identifier. To declare a fixed size buffer field, use the fixed keyword before the field type.
// public bool This[int t] { get { return false; } }
Diagnostic(ErrorCode.ERR_CStyleArray, "[int t]").WithLocation(3, 21),
// (3,22): error CS1525: Invalid expression term 'int'
// public bool This[int t] { get { return false; } }
Diagnostic(ErrorCode.ERR_InvalidExprTerm, "int").WithArguments("int").WithLocation(3, 22),
// (3,22): error CS0270: Array size cannot be specified in a variable declaration (try initializing with a 'new' expression)
// public bool This[int t] { get { return false; } }
Diagnostic(ErrorCode.ERR_ArraySizeInDeclaration, "int").WithLocation(3, 22),
// (3,26): error CS1003: Syntax error, ',' expected
// public bool This[int t] { get { return false; } }
Diagnostic(ErrorCode.ERR_SyntaxError, "t").WithArguments(",").WithLocation(3, 26),
// (3,26): error CS0270: Array size cannot be specified in a variable declaration (try initializing with a 'new' expression)
// public bool This[int t] { get { return false; } }
Diagnostic(ErrorCode.ERR_ArraySizeInDeclaration, "t").WithLocation(3, 26),
// (3,29): error CS1003: Syntax error, ',' expected
// public bool This[int t] { get { return false; } }
Diagnostic(ErrorCode.ERR_SyntaxError, "{").WithArguments(",").WithLocation(3, 29),
// (3,31): error CS1002: ; expected
// public bool This[int t] { get { return false; } }
Diagnostic(ErrorCode.ERR_SemicolonExpected, "get").WithLocation(3, 31),
// (3,35): error CS1519: Invalid token '{' in class, record, struct, or interface member declaration
// public bool This[int t] { get { return false; } }
Diagnostic(ErrorCode.ERR_InvalidMemberDecl, "{").WithArguments("{").WithLocation(3, 35),
// (3,35): error CS1519: Invalid token '{' in class, record, struct, or interface member declaration
// public bool This[int t] { get { return false; } }
Diagnostic(ErrorCode.ERR_InvalidMemberDecl, "{").WithArguments("{").WithLocation(3, 35),
// (3,53): error CS1022: Type or namespace definition, or end-of-file expected
// public bool This[int t] { get { return false; } }
Diagnostic(ErrorCode.ERR_EOFExpected, "}").WithLocation(3, 53),
// (4,1): error CS1022: Type or namespace definition, or end-of-file expected
// }
Diagnostic(ErrorCode.ERR_EOFExpected, "}").WithLocation(4, 1));
}
}
}