When searching for the original file from a PDB, only allow absolute paths #80804
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…paths Without this check, if the PDB in question used path map to create a relative path, it's possible for this check to pass and end up handing around relative paths to the rest of the system (and the VS Shell). This eventually causes other things to break that expect full paths. Given a relative path would only work here by "luck" if the devenv current working directory happened to line up, it seems easiest just to assert it's an absolute path before going further. Fixes dotnet#79014
jasonmalinowski
force-pushed
the
only-allow-fully-qualified-pdb-paths
branch
from
1e0bd35 to
7da3ef7
Compare
dibarbet
approved these changes
Oct 17, 2025
RikkiGibson
approved these changes
Oct 17, 2025
CyrusNajmabadi
approved these changes
Oct 17, 2025
tmat
approved these changes
Oct 17, 2025
This was referenced Oct 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this check, if the PDB in question used path map to create a relative path, it's possible for this check to pass and end up handing around relative paths to the rest of the system (and the VS Shell). This eventually causes other things to break that expect full paths.
Given a relative path would only work here by "luck" if the devenv current working directory happened to line up, it seems easiest just to assert it's an absolute path before going further.
Fixes #79014
Fixes https://developercommunity.visualstudio.com/t/When-external-C-code-file-opened-more-t/10802958 (or at least I think the case that appeared in the customer's private dump)