Dartlab pipeline improvements #81218
Conversation
dibarbet
force-pushed
the
dartlab_improvements
branch
from
db0e004 to
a441ad3
Compare
| $hive = "RoslynDev" | ||
| Write-Host "Using VS Instance $vsId ($displayVersion) at `"$vsDir`"" | ||
| $baseArgs = "/rootSuffix:$hive /quiet /shutdownprocesses" | ||
| try { |
There was a problem hiding this comment.
hide whitespace changes
dibarbet
force-pushed
the
dartlab_improvements
branch
from
a441ad3 to
0c384bb
Compare
dibarbet
force-pushed
the
dartlab_improvements
branch
from
0c384bb to
a1d4059
Compare
| $activityLogPath = Join-Path ${env:USERPROFILE} "AppData\Roaming\Microsoft\VisualStudio\$vsMajorVersion.0_$($vsId)$hive\ActivityLog.xml" | ||
| $devenvExeConfig = Join-Path ${env:USERPROFILE} "AppData\Local\Microsoft\VisualStudio\$vsMajorVersion.0_$($vsId)$hive\devenv.exe.config" | ||
| $mefErrors = Join-Path ${env:USERPROFILE} "AppData\Local\Microsoft\VisualStudio\$vsMajorVersion.0_$($vsId)$hive\ComponentModelCache\Microsoft.VisualStudio.Default.err" |
There was a problem hiding this comment.
This is totally fine, but I wonder if at some point we can capture these as a part of the integration test framework; especially once we move to xunit v3 that has file attachment support.
There was a problem hiding this comment.
This is totally fine, but I wonder if at some point we can capture these as a part of the integration test framework; Especially once we move to xunit v3 that has file attachment support.
I think there is a collector. But the collector only runs as part of the test run. If we don't get to the test run (e.g. crash on resetSettings) then nothing gets collected
jasonmalinowski
left a comment
jasonmalinowski
left a comment
There was a problem hiding this comment.
Just waxing philosophical on a few places, awesome work.
| } | ||
| # InstanceIds is required here to ensure it installs the vsixes only into the specified VS instance. | ||
| # The default installer behavior without it is to install into every installed VS instance. | ||
| $baseArgs = "/rootSuffix:$hive /quiet /shutdownprocesses /instanceIds:$vsId /logFile:$logFileName" |
There was a problem hiding this comment.
Do we need to do quoting for the log file name? I assume we wouldn't get a space...
There was a problem hiding this comment.
Shouldn't no - we generate the file name (and we generate with no spaces).
| - name: sha | ||
| type: string | ||
| default: 'None' | ||
| # Set to 'stop' if you want to keep the test machines around for investigation after test completion. |
3 participants
misc improvements to make debugging easier and improve install