EnC: Block additions to MethodImpl table when targeting .NET Framework #81304
Conversation
dotnet-policy-service
bot
added
VSCode
Needs API Review
|
This PR modifies public API files. Please follow the instructions at https://github.com/dotnet/roslyn/blob/main/docs/contributing/API%20Review%20Process.md for ensuring all public APIs are reviewed before merging. |
|
@DustinCampbell @dotnet/roslyn-compiler ptal |
|
Build failures look real. |
333fred
left a comment
333fred
left a comment
There was a problem hiding this comment.
LGTM, assuming CI is passing.
| or ErrorCode.ERR_SingleInapplicableUnaryOperator | ||
| or ErrorCode.ERR_AmbigOperator | ||
| or ErrorCode.ERR_UnexpectedArgumentListInBaseTypeWithoutParameterList | ||
| or ErrorCode.ERR_EncUpdateRequiresEmittingExplicitInterfaceImplementationNotSupportedByTheRuntime |
There was a problem hiding this comment.
It's EnC-only diagnostic. Not sure if that should be considered build only or not.
There was a problem hiding this comment.
Other EnC diagnostics also return false here. E.g. https://github.com/tmat/roslyn/blob/90015551d370dbab5be5e20e5cec9c627451267e/src/Compilers/CSharp/Portable/Errors/ErrorFacts.cs#L1651
There was a problem hiding this comment.
Not sure if that should be considered build only or not.
I think all emit time diagnostics are build-only diagnostics. Getting a diagnostic for a syntax tree won't return them
| ERRID.ERR_CannotApplyOverloadResolutionPriorityToOverride, | ||
| ERRID.ERR_CannotApplyOverloadResolutionPriorityToMember, | ||
| ERRID.ERR_NextAvailable, | ||
| ERRID.ERR_EncUpdateRequiresEmittingExplicitInterfaceImplementationNotSupportedByTheRuntime, |
| /// The runtime supports adding to InterfaceImpl table. | ||
| /// The runtime supports adding to MethodImpl table. | ||
| /// </summary> | ||
| AddExplicitInterfaceImplementation = 1 << 10, |
There was a problem hiding this comment.
The name of the capability is semi-public. Internally it's represented by the internal enum. Other components use string names, which get translated to the enum value. We match the enum value name to the string.
|
Done with review pass (commit 4) |
4 participants
Block additions to MethodImpl table when targeting .NET Framework.
The EnC impl in .NET Framework doesn't handle them correctly.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2631743 and https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1452066/
Public API change: #81305