Only treat a file with directives as an FBP #81307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dibarbet
approved these changes
Nov 18, 2025
| var isLoadedAsFileBasedProgram = document.FilePath is { } filePath && await IsProjectLoadedAsync(filePath, cancellationToken); | ||
|
|
||
| // If this document has a file-based program syntactic marker, but we aren't loading it in a file-based programs project, | ||
| // we need the caller to remove and re-add this document, so that it gets put in a file-based programs project instead. |
Member
There was a problem hiding this comment.
update this comment to explain how this works (as fddiscussed offline). will tackle improving the clarity of this code in one of the followups I am working on
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #81252
#!or#:to be considered a file-based program.Separately am working on the
#!analyzer described in #81252. Getting the diagnostic to appear in the editor for that has been harder than anticipated so extracting this bit out.