Reduce intermediate array allocations in inline hint implementation #81309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbstractInlineHintService retrieves two intermediate arraysfrom the type and parameter services and then joins them together and returns the resultant array. Instead, pass an ArrayBuilder to the type and parameter services and have them populate it directly, and then only allocate a single IA from the ArrayBuilder.
src/Features/Core/Portable/InlineHints/AbstractInlineParameterNameHintsService.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
approved these changes
Nov 18, 2025
…NameHintsService.cs Co-authored-by: Cyrus Najmabadi <cyrus.najmabadi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AbstractInlineHintService currently retrieves two intermediate arrays from the type and parameter services and then joins them together and returns the resultant array. Instead, pass an ArrayBuilder to the type and parameter services and have them populate it directly, and then only allocate a single IA from the ArrayBuilder.
Test insertion: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/689100
This previously showed as 4.5% (5.0 MB) of RoslynCodeAnalysisService allocations in the html completion scenario in the RazorEditingTests.CompletionInCohosting speedometer test. With this change, allocations of the InlineHint[] went down to 1.8% (2.1 MB)
*** BEFORE ***
*** AFTER (roslyn symbols didn't load for some reason) ***
