Add IOp support for with(...) elements.
#81427
Open
+3,364
−138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-arguments' into creationArguments
…y.cs Co-authored-by: Rikki Gibson <rikkigibson@gmail.com>
Co-authored-by: Rikki Gibson <rikkigibson@gmail.com>
…/roslyn into creationArguments
dotnet-policy-service
bot
added
the
Needs API Review
Contributor
|
This PR modifies public API files. Please follow the instructions at https://github.com/dotnet/roslyn/blob/main/docs/contributing/API%20Review%20Process.md for ensuring all public APIs are reviewed before merging. |
Member
Author
|
@AlekseyTs Looks like we'll need to move over here. |
jcouv
added
Feature - Collection Arguments
jcouv
reviewed
Nov 25, 2025
| Microsoft.CodeAnalysis.INamedTypeSymbol.ExtensionParameter.get -> Microsoft.CodeAnalysis.IParameterSymbol? | ||
| Microsoft.CodeAnalysis.INamedTypeSymbol.IsExtension.get -> bool | ||
| Microsoft.CodeAnalysis.IPropertySymbol.ReduceExtensionMember(Microsoft.CodeAnalysis.ITypeSymbol! receiverType) -> Microsoft.CodeAnalysis.IPropertySymbol? | ||
| Microsoft.CodeAnalysis.OperationKind.CollectionExpressionElementsPlaceholder = 129 -> Microsoft.CodeAnalysis.OperationKind |
Member
There was a problem hiding this comment.
Let's also update the API proposal with latest shape
jcouv
reviewed
Nov 25, 2025
| </summary> | ||
| <remarks> | ||
| If the invocation is in its expanded form, then params/ParamArray arguments would be collected into arrays. | ||
| Default values are supplied for optional arguments missing in source. |
Member
There was a problem hiding this comment.
nit: consider mentioning ICollectionExpressionElementsPlaceholderOperation
jcouv
reviewed
Nov 25, 2025
| // Tracked by https://github.com/dotnet/roslyn/issues/68826 | ||
| VerifyOperationTreeForTest<CollectionExpressionSyntax>(comp, | ||
| """ | ||
| VerifyOperationTreeForTest<CollectionExpressionSyntax>(comp, """ |
Member
There was a problem hiding this comment.
nit: The tracked issue above is closed. Remove link?
Member
Author
|
@dotnet/roslyn-compiler ptal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to test plan #80613
Closes #80998