AI Rename UI: fix highlighted item on focus #81445
Conversation
dotnet-policy-service
bot
added
Community
|
After def looks good. I have no idea how the UI framework works though. @JoeRobich can you ptal? |
| // update the ComboBox selection to match the focused item | ||
| if (e.NewFocus is ComboBoxItem comboBoxItem && comboBoxItem.DataContext != null) | ||
| { | ||
| SelectedItem = comboBoxItem.DataContext; |
There was a problem hiding this comment.
Seems like we wouldn't want to select the item until the user hits enter or space.
There was a problem hiding this comment.
Joey, "Seems like we wouldn't want to select the item until the user hits enter or space." is not consistent with current behavior.
Without this event handler, the highlighted item does not get previewed. Then, upon pressing Enter, it's not going to be committed (because it's not inserted into the TextBox)
That's not how we currently handle up/down, where the item is selected, inserted into the TextBox, and ultimately used for rename on Enter.
The above code makes the TAB selection behave the same way as Up/Down selection ^
| // update the ComboBox selection to match the focused item | ||
| if (e.NewFocus is ComboBoxItem comboBoxItem && comboBoxItem.DataContext != null) | ||
| { | ||
| SelectedItem = comboBoxItem.DataContext; |
There was a problem hiding this comment.
Seems like we wouldn't want to select the item until the user hits enter or space.
5 participants
We have an accessibility bug (azdo 2615738) for the Smart Rename UI, where the focus indicator is hard to see when user set keyboard focus on an item using Tab, instead of the typical Up/Down that works correctly.
Before: (note focus is on the "DashboardController" item)
After:
