Mark ERR_FunctionPointerTypesInAttributeNotSupported as build-only #81453
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Dumb quesstion. Why is this not a normal binding time error? why does it happen during build only? |
CyrusNajmabadi
approved these changes
Nov 26, 2025
Member
Author
|
Currently this error is reported inside TypeNameSerializer whenever it visits a function pointer. That seems more reliable than trying to figure out all the places in binding which could lead to us trying to serialize a fnptr later during emit. But it could definitely be improved by catching at least some places during binding and leaving the emit error as a fallback. |
Member
Thanks :) If it is too complex to check during binding, that makes sense to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.