-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Un-obsolete extension ITypeSymbol APIs #82192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Is the intent for tis to be permanent or is it being done temporarily to unblock boot strapping? |
Permanent. The potential problems with removing this later seem to outweigh the benefits. There is nothing wrong with having the APIs on ITypeSymbol, so API review decided we can just have them there permanently. |
jcouv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks (commit 1)
|
Is this related to #82131 where we're now marking all new APIs as experimental? |
Yes, moving forward, we're planning to have APIs related to preview features to be marked as experimental until we stamp a new language version as released. In that release, we'll consider the APIs as shipped and no longer experimental. This should avoid a customer accidentally taking a dependency on an API for a feature while still in preview. |
This will be super useful. Now we can pragma suppress during development then do a scan before we ship that we don’t have any suppressions. |
Resolves #82148 per yesterday's API review decision.