Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support showing diagnostics on additional files. #8525

Closed
wants to merge 5 commits into from

Conversation

heejaechang
Copy link
Contributor

this change is turned off by default. and can be turned on by reg key to dogfood changes.

this only let analyzer author to report such diagnostics but consumer doesnt have any knob to control (including suppressing it) yet.

this change is turned off by default. and can be turned on by reg key to dogfood changes.

this only let analyzer author to report such diagnostics but consumer doesnt have any knob to control (including suppressing it) yet.
@heejaechang
Copy link
Contributor Author

@dotnet/roslyn-infrastructure a lot of tests are timed out.

@heejaechang
Copy link
Contributor Author

prototype of #6649

@heejaechang
Copy link
Contributor Author

@mavasani @srivatsn @basoundr can you take a look? I probably check this in after update 2.

@heejaechang
Copy link
Contributor Author

existing build time out issue.

@heejaechang
Copy link
Contributor Author

retest prtest/win/dbg/unit64 please

@heejaechang
Copy link
Contributor Author

retest prtest/win/dbg/unit32 please

@jaredpar
Copy link
Member

We apologize, but we are closing this PR due to code drift. We regret letting this PR go so long without attention, but at this point the code base has changed too much for us to revisit older PRs. Going forward, we will manage PRs better under an SLA currently under draft in issue #26266 – we encourage you to add comments to that draft as you see fit. Although that SLA is still in draft form, we nevertheless want to move forward with the identification of older PRs to give contributors as much early notice as possible to review and update them.

If you are interested in pursuing this PR, please reset it against the head of master and we will reopen it. Thank you!

@jaredpar jaredpar closed this Apr 19, 2018
@sharwell sharwell added the Resolution-Expired The request is closed due to inactivity under our contribution review policy. label Apr 19, 2018
@mavasani
Copy link
Contributor

mavasani commented Jul 3, 2018

@heejaechang I presume reviving this PR will automatically show squiggles in all additional files?

@heejaechang
Copy link
Contributor Author

@mavasani this is really old PR that targets V1 engine not V2.

also, this just makes sure engine process addition files but no presentation work is in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Analyzers cla-already-signed Resolution-Expired The request is closed due to inactivity under our contribution review policy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants