-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support showing diagnostics on additional files. #8525
Conversation
this change is turned off by default. and can be turned on by reg key to dogfood changes. this only let analyzer author to report such diagnostics but consumer doesnt have any knob to control (including suppressing it) yet.
@dotnet/roslyn-infrastructure a lot of tests are timed out. |
prototype of #6649 |
existing build time out issue. |
retest prtest/win/dbg/unit64 please |
retest prtest/win/dbg/unit32 please |
We apologize, but we are closing this PR due to code drift. We regret letting this PR go so long without attention, but at this point the code base has changed too much for us to revisit older PRs. Going forward, we will manage PRs better under an SLA currently under draft in issue #26266 – we encourage you to add comments to that draft as you see fit. Although that SLA is still in draft form, we nevertheless want to move forward with the identification of older PRs to give contributors as much early notice as possible to review and update them. If you are interested in pursuing this PR, please reset it against the head of master and we will reopen it. Thank you! |
@heejaechang I presume reviving this PR will automatically show squiggles in all additional files? |
@mavasani this is really old PR that targets V1 engine not V2. also, this just makes sure engine process addition files but no presentation work is in. |
this change is turned off by default. and can be turned on by reg key to dogfood changes.
this only let analyzer author to report such diagnostics but consumer doesnt have any knob to control (including suppressing it) yet.