Add .slnx support #1662
Merged
Add .slnx support #1662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@dotnet-policy-service agree company="Microsoft" |
commit 219124e Author: Chris Trevino <chtrevin@microsoft.com> Date: Tue Jul 1 22:02:34 2025 -0700 dotnet format commit f721781 Author: Chris Trevino <chtrevin@microsoft.com> Date: Tue Jul 1 21:57:24 2025 -0700 add pragma disable commit b645a59 Author: Chris Trevino <chtrevin@microsoft.com> Date: Tue Jul 1 21:47:40 2025 -0700 remove net7.0 targets (deprecated) commit 85b7920 Author: Chris Trevino <chtrevin@microsoft.com> Date: Tue Jul 1 21:42:00 2025 -0700 conditional Microsoft.Build import commit 7ce673f Author: Chris Trevino <chtrevin@microsoft.com> Date: Tue Jul 1 21:20:28 2025 -0700 drop net7.0 commit f26dd93 Author: Chris Trevino <chtrevin@microsoft.com> Date: Tue Jul 1 21:08:32 2025 -0700 update dotnet 9.0.x install commit c8f9262 Author: Chris Trevino <chtrevin@microsoft.com> Date: Tue Jul 1 21:02:57 2025 -0700 leave roslynator.sln commit 88581a4 Author: Chris Trevino <chtrevin@microsoft.com> Date: Tue Jul 1 20:55:47 2025 -0700 test fix commit 922110c Author: Chris Trevino <chtrevin@microsoft.com> Date: Tue Jul 1 20:44:34 2025 -0700 fix lint issue commit 4782f89 Author: Chris Trevino <chtrevin@microsoft.com> Date: Tue Jul 1 20:41:52 2025 -0700 fix lint violation commit cf5a4ed Merge: 27d7848 1384df8 Author: Chris Trevino <chtrevin@microsoft.com> Date: Tue Jul 1 20:36:51 2025 -0700 Merge branch 'dathtrevino/feat/slnx_support' into task/slnx_everything commit 27d7848 Author: Chris Trevino <chtrevin@microsoft.com> Date: Tue Jul 1 11:43:53 2025 -0700 slnx everything
Collaborator
|
Hey @darthtrevino, Thank your for the PR. If I may ask you please don't mix support for slnx in command-line tool with migrating this project to slnx. If you would like to migrate this project to slnx please open an issue first and discuss it. Thanks. |
Contributor
Author
|
Yep, sure thing, I'll revert those changes |
josefpihrt
reviewed
Jul 26, 2025
Collaborator
josefpihrt
left a comment
josefpihrt
left a comment
There was a problem hiding this comment.
Please update changelog, also mentioning that Roslyn version was bumped for CLI (you can find it in changelog mentioned before).
src/CommandLine.DocumentationGenerator/CommandLine.DocumentationGenerator.csproj
Show resolved
Hide resolved
…Tests.cs Co-authored-by: Josef Pihrt <josef@pihrt.net>
Co-authored-by: Josef Pihrt <josef@pihrt.net>
josefpihrt
approved these changes
Aug 8, 2025
Collaborator
|
@darthtrevino Thanks for the contribution! |
This was referenced Oct 6, 2025
This was referenced Oct 22, 2025
Merged
Merged
This was referenced Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows up with #1640.
The issues referenced in that PR have all been resolved, but I needed to make a few changes to get slnx parsing working, including:
It's been a while since I've worked in a .NET project, so you might want to double-check my changes, and make sure this will work for users in .net 7 and 8 environments.
fixes #1639