Skip to content

Commit

Permalink
Add -skipcrossarchnative and -verbose options (#90554)
Browse files Browse the repository at this point in the history
* Add CoreclrVerbose=true when --verbose is passed as option to build.sh

Sponsored by: Tekvox Inc.
Cc: Jim Reinhart <jimr@tekvox.com>
Cc: James Autry <jautry@tekvox.com>
Cc: Matthew Maron <matthewm@tekvox.com>
Signed-off-by: Giulio Benetti <giulio.benetti+tekvox@benettiengineering.com>

* Remove leftover comment about -skipcrossarchnative

During commit 7d562f9 comment about
-skipcrossarchnative has been forgotten, so let's remove it since that
flag is not available anymore.

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

* Correct shift value

---------

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
Co-authored-by: Giulio Benetti <giulio.benetti+tekvox@benettiengineering.com>
Co-authored-by: Juan Hoyos <19413848+hoyosjs@users.noreply.github.com>
  • Loading branch information
3 people committed Oct 5, 2023
1 parent 55be11c commit 0e8523e
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions eng/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -524,6 +524,11 @@ while [[ $# > 0 ]]; do
shift 2
;;

-verbose)
arguments="$arguments /p:CoreclrVerbose=true"
shift 1
;;

*)
extraargs="$extraargs $1"
shift 1
Expand Down
1 change: 0 additions & 1 deletion src/coreclr/build-runtime.sh
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ export PYTHON

usage_list+=("-pgodatapath: path to profile guided optimization data.")
usage_list+=("-pgoinstrument: generate instrumented code for profile guided optimization enabled binaries.")
usage_list+=("-skipcrossarchnative: Skip building cross-architecture native binaries.")
usage_list+=("-staticanalyzer: use scan_build static analyzer.")
usage_list+=("-component: Build individual components instead of the full project. Available options are 'hosts', 'jit', 'runtime', 'paltests', 'alljits', 'iltools', 'nativeaot', and 'spmi'. Can be specified multiple times.")
usage_list+=("-subdir: Append a directory with the provided name to the obj and bin paths.")
Expand Down
1 change: 1 addition & 0 deletions src/coreclr/runtime.proj
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
<_CoreClrBuildArg Condition="'$(PortableBuild)' != 'true'" Include="-portablebuild=false" />
<_CoreClrBuildArg Condition="'$(KeepNativeSymbols)' != 'false'" Include="-keepnativesymbols" />
<_CoreClrBuildArg Include="-os $(_BuildNativeTargetOS)" />
<_CoreClrBuildArg Condition="'$(CoreclrVerbose)' == 'true'" Include="-verbose" />

<_CoreClrBuildArg Condition="$([MSBuild]::IsOsPlatform(Windows)) and
('$(TargetArchitecture)' == 'x86' or '$(TargetArchitecture)' == 'x64') and
Expand Down

0 comments on commit 0e8523e

Please sign in to comment.