Skip to content

Commit

Permalink
Fix test framework crossgening (#42874)
Browse files Browse the repository at this point in the history
The recent change that replaced direct invocation of crossgen and
crossgen2 for crossgening framework assemblies for coreclr tests by
r2rtest tool usage has ommited the --release and --large-bubble
arguments. These correspond to the former -O and --inputbubble crossgen2
commands and should be present.

This also fixes failures in running tests with the crossgened runtime.
Many tests were failing with the error `Could not execute the method
because either the method itself or the containing type is not fully
instantiated.`

So while there is a problem to investigate related to debug flavor of
crossgening, this PR fixes the options.
  • Loading branch information
janvorli authored Sep 30, 2020
1 parent 994dca6 commit 13b457a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/tests/build.cmd
Original file line number Diff line number Diff line change
Expand Up @@ -629,7 +629,7 @@ exit /b 1

:PrecompileFX

set __CrossgenCmd="%__RepoRootDir%\dotnet.cmd" "%CORE_ROOT%\R2RTest\R2RTest.dll" compile-framework -cr "%CORE_ROOT%" --output-directory "%CORE_ROOT%\crossgen.out" --target-arch %__BuildArch% -dop %NUMBER_OF_PROCESSORS%
set __CrossgenCmd="%__RepoRootDir%\dotnet.cmd" "%CORE_ROOT%\R2RTest\R2RTest.dll" compile-framework -cr "%CORE_ROOT%" --output-directory "%CORE_ROOT%\crossgen.out" --large-bubble --release --target-arch %__BuildArch% -dop %NUMBER_OF_PROCESSORS%

if defined __CompositeBuildMode (
set __CrossgenCmd=%__CrossgenCmd% --composite
Expand Down

0 comments on commit 13b457a

Please sign in to comment.