Skip to content

Commit

Permalink
[wasm] Fix runtime test failing due to the app running in debug mode (#…
Browse files Browse the repository at this point in the history
…70050)

* [wasm] Fix runtime test failing due to the app running in debug mode

Fixes #69517

- Recent [wasm-app-host commit](6b3ea40) changed `WasmApp.targets` so
  `WasmDebugLevel` would be set to enable debugging if
  `Configuration==Debug`.
    - this broke some runtime tests which depend on tail call
    optimizations, which get disabled when debugging is enabled in the
    runtime.

- And the wasm apps for the runtime tests are being built with no
  configuration set, which defaults to `Debug`. Instead, propogate the
  config for the build to the wasm proxy (`WasmTestRunner`) projects too.

Fixes #69517 .

* Revert "[wasm] Disable runtime test failing due to stack overflow (#69863)"

This reverts commit 61441fa.
  • Loading branch information
radical authored Jun 1, 2022
1 parent 9d84900 commit 174a894
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 8 deletions.
2 changes: 1 addition & 1 deletion src/tests/Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@
</PropertyGroup>

<PropertyGroup Condition="'$(TargetOS)' == 'Browser'">
<CLRTestMSBuildArgs>/p:MSBuildEnableWorkloadResolver=false</CLRTestMSBuildArgs>
<CLRTestMSBuildArgs>/p:MSBuildEnableWorkloadResolver=false /p:Configuration=$(Configuration)</CLRTestMSBuildArgs>
</PropertyGroup>

<PropertyGroup Condition="'$(IsTestsCommonProject)' != 'true'">
Expand Down
7 changes: 0 additions & 7 deletions src/tests/issues.targets
Original file line number Diff line number Diff line change
Expand Up @@ -3291,13 +3291,6 @@


<ItemGroup Condition=" '$(TargetArchitecture)' == 'wasm' " >
<ExcludeList Include="$(XunitTestBinBase)/JIT/Directed/tailcall/**">
<Issue>https://github.com/dotnet/runtime/issues/69517</Issue>
</ExcludeList>
<ExcludeList Include="$(XunitTestBinBase)/JIT/Directed/IL/Tailcall/ExplicitTailCallNoSO/*">
<Issue>https://github.com/dotnet/runtime/issues/69517</Issue>
</ExcludeList>

<ExcludeList Include="$(XunitTestBinBase)/JIT/Intrinsics/TypeIntrinsics_r/**">
<Issue>https://github.com/dotnet/runtime/issues/54867</Issue>
</ExcludeList>
Expand Down

0 comments on commit 174a894

Please sign in to comment.