Skip to content

Commit

Permalink
Enable disabled QUIC tests (#56590)
Browse files Browse the repository at this point in the history
With update updated MsQuic on Linux in place (PR #56429) we should pass few more disabled tests.
I did ~200 local runs and I did not see any problems

Fixes #55242
Fixes #55746
  • Loading branch information
wfurt authored Jul 30, 2021
1 parent fae1412 commit 38071bf
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ private static async Task<QuicStream> OpenAndUseStreamAsync(QuicConnection c)
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/55242", TestPlatforms.Linux)]
public async Task CloseAsync_WithPendingAcceptAndConnect_PendingAndSubsequentThrowOperationAbortedException()
{
using var sync = new SemaphoreSlim(0);
Expand Down Expand Up @@ -96,7 +95,6 @@ await RunClientServer(
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/55242", TestPlatforms.Linux)]
public async Task Dispose_WithPendingAcceptAndConnect_PendingAndSubsequentThrowOperationAbortedException()
{
using var sync = new SemaphoreSlim(0);
Expand Down Expand Up @@ -130,7 +128,6 @@ await RunClientServer(
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/55242", TestPlatforms.Linux)]
public async Task ConnectionClosedByPeer_WithPendingAcceptAndConnect_PendingAndSubsequentThrowConnectionAbortedException()
{
if (IsMockProvider)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -573,8 +573,7 @@ await RunClientServer(
await using QuicStream stream = await connection.AcceptStreamAsync();

QuicStreamAbortedException ex = await Assert.ThrowsAsync<QuicStreamAbortedException>(() => WriteForever(stream));
// [ActiveIssue("https://github.com/dotnet/runtime/issues/55746")]
//Assert.Equal(expectedErrorCode, ex.ErrorCode);
Assert.Equal(expectedErrorCode, ex.ErrorCode);

// We should still return true from CanWrite, even though the write has been aborted.
Assert.True(stream.CanWrite);
Expand Down

0 comments on commit 38071bf

Please sign in to comment.