Skip to content

Commit

Permalink
correct perf-send-to-helix on windows (#42235)
Browse files Browse the repository at this point in the history
* correct perf helix workitems on windows

* Will Revert: turn on PR validation

* change Agent.Os to runtime var

* remove sendparams condition

* test if macro syntax var case sensitive

* try expression for Agent.Os

* try $(Agent.Os)

* pass osGroup param

* revert pr trigger:
  • Loading branch information
ooooolivia authored Sep 17, 2020
1 parent 6c27393 commit 3d75475
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 1 deletion.
3 changes: 2 additions & 1 deletion eng/common/templates/steps/perf-send-to-helix.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,13 @@ parameters:
DisplayNamePrefix: 'Send job to Helix' # optional -- rename the beginning of the displayName of the steps in AzDO
condition: succeeded() # optional -- condition for step to execute; defaults to succeeded()
continueOnError: false # optional -- determines whether to continue the build if the step errors; defaults to false
osGroup: '' # required -- operating system for the job


steps:
- template: /eng/pipelines/common/templates/runtimes/send-to-helix-inner-step.yml
parameters:
osGroup: ${{ variables['Agent.Os'] }}
osGroup: ${{ parameters.osGroup }}
sendParams: $(Build.SourcesDirectory)/eng/common/performance/${{ parameters.ProjectFile }} /restore /t:Test /bl:$(Build.SourcesDirectory)/artifacts/log/$(_BuildConfig)/SendToHelix.binlog
displayName: ${{ parameters.DisplayNamePrefix }}
condition: ${{ parameters.condition }}
Expand Down
1 change: 1 addition & 0 deletions eng/pipelines/coreclr/templates/run-performance-job.yml
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,7 @@ jobs:
WorkItemDirectory: '$(WorkItemDirectory)' # WorkItemDirectory can not be empty, so we send it some docs to keep it happy
CorrelationPayloadDirectory: '$(PayloadDirectory)' # it gets checked out to a folder with shorter path than WorkItemDirectory so we can avoid file name too long exceptions
ProjectFile: ${{ parameters.projectFile }}
osGroup: ${{ parameters.osGroup }}
- task: PublishPipelineArtifact@1
displayName: Publish Logs
inputs:
Expand Down
1 change: 1 addition & 0 deletions eng/pipelines/coreclr/templates/run-scenarios-job.yml
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,7 @@ jobs:
WorkItemDirectory: '$(WorkItemDirectory)' # contains scenario tools, shared python scripts, dotnet tool
CorrelationPayloadDirectory: '$(PayloadDirectory)' # contains performance repo and built product
ProjectFile: ${{ parameters.projectFile }}
osGroup: ${{ parameters.osGroup }}

# publish logs
- task: PublishPipelineArtifact@1
Expand Down

0 comments on commit 3d75475

Please sign in to comment.