Skip to content

Commit

Permalink
[Mono] Enable X86Base.Pause test only when LLVM is enabled (#73318)
Browse files Browse the repository at this point in the history
* Enable test only when LLVM is enabled

* Add back SIMD intrinsics support for X86Base.Pause

* Disable test for llvm
  • Loading branch information
fanyang-mono authored Aug 9, 2022
1 parent acc4f23 commit 3fcbcc2
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
1 change: 1 addition & 0 deletions src/mono/mono/mini/simd-intrinsics.c
Original file line number Diff line number Diff line change
Expand Up @@ -3296,6 +3296,7 @@ static SimdIntrinsic bmi2_methods [] = {
static SimdIntrinsic x86base_methods [] = {
{SN_BitScanForward},
{SN_BitScanReverse},
{SN_Pause, OP_XOP, INTRINS_SSE_PAUSE},
{SN_get_IsSupported}
};

Expand Down
1 change: 1 addition & 0 deletions src/mono/mono/mini/simd-methods.h
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,7 @@ METHOD(ComputeCrc32C)
// X86Base
METHOD(BitScanForward)
METHOD(BitScanReverse)
METHOD(Pause)
// Crypto
METHOD(FixedRotate)
METHOD(HashUpdateChoose)
Expand Down
7 changes: 3 additions & 4 deletions src/tests/issues.targets
Original file line number Diff line number Diff line change
Expand Up @@ -1434,10 +1434,6 @@
<ExcludeList Include = "$(XUnitTestBinBase)/JIT/Directed/Arrays/nintindexoutofrange/**">
<Issue>https://github.com/dotnet/runtime/issues/71656</Issue>
</ExcludeList>
<ExcludeList Include = "$(XUnitTestBinBase)/JIT/HardwareIntrinsics/X86/X86Base/Pause*/**">
<Issue>https://github.com/dotnet/runtime/issues/61693</Issue>
</ExcludeList>

<ExcludeList Include = "$(XunitTestBinBase)/reflection/GenericAttribute/**">
<Issue>https://github.com/dotnet/runtime/issues/56887</Issue>
</ExcludeList>
Expand Down Expand Up @@ -3052,6 +3048,9 @@
<ExcludeList Include="$(XunitTestBinBase)/JIT/Regression/CLR-x86-JIT/V1.1-M1-Beta1/b143840/b143840/*">
<Issue>https://github.com/dotnet/runtime/issues/48914</Issue>
</ExcludeList>
<ExcludeList Include = "$(XUnitTestBinBase)/JIT/HardwareIntrinsics/X86/X86Base/Pause*/**">
<Issue>https://github.com/dotnet/runtime/issues/73454;https://github.com/dotnet/runtime/pull/61707#issuecomment-973122341</Issue>
</ExcludeList>
<ExcludeList Include = "$(XunitTestBinBase)/tracing/eventpipe/eventsourceerror/**">
<Issue> needs triage </Issue>
</ExcludeList>
Expand Down

0 comments on commit 3fcbcc2

Please sign in to comment.