Skip to content

Commit

Permalink
Enable all configurations inner loop (#108848)
Browse files Browse the repository at this point in the history
* Revert "Disable linux-x64 dev-innerloop (#108581)"

This reverts commit 7b69459.

* Don't build tests in linux_x64_dev_innerloop

Testing to determine if building tests were the source of OOMs in CI
  • Loading branch information
ericstj authored Oct 14, 2024
1 parent 0212c3d commit 44978f0
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 20 deletions.
35 changes: 17 additions & 18 deletions eng/pipelines/common/platform-matrix.yml
Original file line number Diff line number Diff line change
Expand Up @@ -298,24 +298,23 @@ jobs:

# Runtime-dev-innerloop build

# disabled against https://github.com/dotnet/runtime/issues/108821
#- ${{ if containsValue(parameters.platforms, 'linux_x64_dev_innerloop') }}:
# - template: xplat-setup.yml
# parameters:
# jobTemplate: ${{ parameters.jobTemplate }}
# helixQueuesTemplate: ${{ parameters.helixQueuesTemplate }}
# variables: ${{ parameters.variables }}
# osGroup: linux
# archType: x64
# targetRid: linux-x64
# platform: linux_x64
# shouldContinueOnError: ${{ parameters.shouldContinueOnError }}
# container: linux_x64_dev_innerloop
# jobParameters:
# runtimeFlavor: ${{ parameters.runtimeFlavor }}
# buildConfig: ${{ parameters.buildConfig }}
# helixQueueGroup: ${{ parameters.helixQueueGroup }}
# ${{ insert }}: ${{ parameters.jobParameters }}
- ${{ if containsValue(parameters.platforms, 'linux_x64_dev_innerloop') }}:
- template: xplat-setup.yml
parameters:
jobTemplate: ${{ parameters.jobTemplate }}
helixQueuesTemplate: ${{ parameters.helixQueuesTemplate }}
variables: ${{ parameters.variables }}
osGroup: linux
archType: x64
targetRid: linux-x64
platform: linux_x64
shouldContinueOnError: ${{ parameters.shouldContinueOnError }}
container: linux_x64_dev_innerloop
jobParameters:
runtimeFlavor: ${{ parameters.runtimeFlavor }}
buildConfig: ${{ parameters.buildConfig }}
helixQueueGroup: ${{ parameters.helixQueueGroup }}
${{ insert }}: ${{ parameters.jobParameters }}

- ${{ if containsValue(parameters.platforms, 'linux_musl_x64_dev_innerloop') }}:
- template: xplat-setup.yml
Expand Down
4 changes: 2 additions & 2 deletions eng/pipelines/global-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ extends:
eq(variables['isRollingBuild'], true))

#
# Build Libraries AllConfigurations. This exercises the code path where we build libraries and tests for all
# Build Libraries AllConfigurations. This exercises the code path where we build libraries for all
# configurations on a non Windows operating system.
#
- template: /eng/pipelines/common/platform-matrix.yml
Expand All @@ -93,7 +93,7 @@ extends:
- linux_x64_dev_innerloop
jobParameters:
nameSuffix: Libraries_AllConfigurations
buildArgs: -subset libs+libs.tests -allconfigurations
buildArgs: -subset libs -allconfigurations
timeoutInMinutes: 120
condition:
or(
Expand Down

0 comments on commit 44978f0

Please sign in to comment.