Testing CI

Author: MichalStrehovsky

src/coreclr/tools/Common/TypeSystem/Common/SignatureVariable.cs

@@ -66,7 +66,16 @@ protected override TypeFlags ComputeTypeFlags(TypeFlags mask)
                 flags |= TypeFlags.SignatureTypeVariable;
             }
 
-            flags |= TypeFlags.AttributeCacheComputed;
+            // ******************************************************
+            // Do not add other flags here. If you're hitting asserts
+            // because a flag wasn't set, this is a bug in the
+            // calling code. The fix is not here.
+            //
+            // The calling code is asking questions that are not
+            // possible to answer for signature variables
+            // (like: is this ByRef-like? We won't know until
+            // a substitution happens. Any answer would be wrong.)
+            // ******************************************************
 
             return flags;
         }
@@ -105,6 +114,17 @@ protected override TypeFlags ComputeTypeFlags(TypeFlags mask)
                 flags |= TypeFlags.SignatureMethodVariable;
             }
 
+            // ******************************************************
+            // Do not add other flags here. If you're hitting asserts
+            // because a flag wasn't set, this is a bug in the
+            // calling code. The fix is not here.
+            //
+            // The calling code is asking questions that are not
+            // possible to answer for signature variables
+            // (like: is this ByRef-like? We won't know until
+            // a substitution happens. Any answer would be wrong.)
+            // ******************************************************
+
             return flags;
         }