Skip to content

Commit

Permalink
[wasm] Bump chrome for testing - linux: 128.0.6613.119, windows: 128.…
Browse files Browse the repository at this point in the history
…0.6613.120 (#107504)

* Automated bump of chrome version

* Addning new `BrowserArguments` is possible without changes on xharness side.

* Add `--disable-gpu` to lib tests as well.

* Set `PageLoadStrategy=NONE` for browser on Windows to avoid timeouts in driver-browser communication.

* Remove whitespace.

* Set the fixing flag for lib tests on Windows.

* Fix: add args to chrome scenario, not node.

* Move appended WBT args to one place.

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Ilona Tomkowicz <32700855+ilonatommy@users.noreply.github.com>
Co-authored-by: Larry Ewing <lewing@microsoft.com>
Co-authored-by: Ilona Tomkowicz <itomkowicz@microsoft.com>
  • Loading branch information
5 people authored Sep 19, 2024
1 parent e8613a6 commit 51bd2b9
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 9 deletions.
16 changes: 8 additions & 8 deletions eng/testing/BrowserVersions.props
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
<Project>
<PropertyGroup>
<linux_ChromeVersion>126.0.6478.114</linux_ChromeVersion>
<linux_ChromeRevision>1300313</linux_ChromeRevision>
<linux_ChromeBaseSnapshotUrl>https://storage.googleapis.com/chromium-browser-snapshots/Linux_x64/1300316</linux_ChromeBaseSnapshotUrl>
<linux_V8Version>12.6.228</linux_V8Version>
<win_ChromeVersion>126.0.6478.36</win_ChromeVersion>
<win_ChromeRevision>1300313</win_ChromeRevision>
<win_ChromeBaseSnapshotUrl>https://storage.googleapis.com/chromium-browser-snapshots/Win_x64/1300320</win_ChromeBaseSnapshotUrl>
<win_V8Version>12.6.228</win_V8Version>
<linux_ChromeVersion>128.0.6613.119</linux_ChromeVersion>
<linux_ChromeRevision>1331488</linux_ChromeRevision>
<linux_ChromeBaseSnapshotUrl>https://storage.googleapis.com/chromium-browser-snapshots/Linux_x64/1331503</linux_ChromeBaseSnapshotUrl>
<linux_V8Version>12.8.374</linux_V8Version>
<win_ChromeVersion>128.0.6613.120</win_ChromeVersion>
<win_ChromeRevision>1331488</win_ChromeRevision>
<win_ChromeBaseSnapshotUrl>https://storage.googleapis.com/chromium-browser-snapshots/Win_x64/1331504</win_ChromeBaseSnapshotUrl>
<win_V8Version>12.8.374</win_V8Version>
<linux_FirefoxRevision>125.0.1</linux_FirefoxRevision>
<linux_GeckoDriverRevision>0.34.0</linux_GeckoDriverRevision>
<win_FirefoxRevision>125.0.1</win_FirefoxRevision>
Expand Down
2 changes: 1 addition & 1 deletion eng/testing/WasmRunnerTemplate.cmd
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ if /I [%XHARNESS_COMMAND%] == [test] (
set "BROWSER_PATH=--browser-path^=%HELIX_CORRELATION_PAYLOAD%\chrome-win\chrome.exe"
)
if [%JS_ENGINE_ARGS%] == [] (
set "JS_ENGINE_ARGS=--browser-arg^=--js-flags^=--stack-trace-limit^=1000"
set "JS_ENGINE_ARGS=--browser-arg^=--js-flags^=--stack-trace-limit^=1000 --browser-arg^=--disable-gpu --pageLoadStrategy=none"
)
) else (
if /I [%SCENARIO%] == [WasmTestOnFirefox] (
Expand Down
2 changes: 2 additions & 0 deletions src/mono/wasm/Wasm.Build.Tests/BuildTestBase.cs
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,8 @@ protected static string RunWithXHarness(string testCommand, string testLogPath,
args.Append($" --output-directory={testLogPath}");
args.Append($" --expected-exit-code={expectedAppExitCode}");
args.Append($" {extraXHarnessArgs ?? string.Empty}");
args.Append(" --browser-arg=--disable-gpu");
args.Append(" --pageLoadStrategy=none");

// `/.dockerenv` - is to check if this is running in a codespace
if (File.Exists("/.dockerenv"))
Expand Down

0 comments on commit 51bd2b9

Please sign in to comment.