Call simpler overloads of Substring and Slice (#68937)

src/coreclr/tools/Common/Compiler/Logging/DocumentationSignatureParser.cs

@@ -538,7 +538,7 @@ static void GetMatchingTypes(ModuleDesc module, TypeDesc declaringType, string n
  if (indexOfLastDot > 0 && indexOfLastDot < name.Length - 1)
  {
  namespacepart = name.Substring(indexOfLastDot - 1);
- namepart = name.Substring(indexOfLastDot + 1, name.Length - indexOfLastDot - 1);
+ namepart = name.Substring(indexOfLastDot + 1);
  }
  else
  {

src/coreclr/tools/aot/ILCompiler/Program.cs

@@ -460,7 +460,7 @@ private int Run(string[] args)
  Dictionary<string, bool> instructionSetSpecification = new Dictionary<string, bool>();
  foreach (string instructionSetSpecifier in instructionSetParams)
  {
- string instructionSet = instructionSetSpecifier.Substring(1, instructionSetSpecifier.Length - 1);
+ string instructionSet = instructionSetSpecifier.Substring(1);
 
  bool enabled = instructionSetSpecifier[0] == '+' ? true : false;
  if (enabled)

src/coreclr/tools/aot/crossgen2/Program.cs

@@ -262,7 +262,7 @@ private InstructionSetSupport ConfigureInstructionSetSupport()
  Dictionary<string, bool> instructionSetSpecification = new Dictionary<string, bool>();
  foreach (string instructionSetSpecifier in instructionSetParams)
  {
- string instructionSet = instructionSetSpecifier.Substring(1, instructionSetSpecifier.Length - 1);
+ string instructionSet = instructionSetSpecifier.Substring(1);
 
  bool enabled = instructionSetSpecifier[0] == '+' ? true : false;
  if (enabled)

src/libraries/Microsoft.Win32.Registry/src/Microsoft/Win32/Registry.cs

@@ -56,7 +56,7 @@ private static RegistryKey GetBaseKeyFromKeyName(string keyName, out string subK
  {
  subKeyName = (i == -1 || i == keyName.Length) ?
  string.Empty :
- keyName.Substring(i + 1, keyName.Length - i - 1);
+ keyName.Substring(i + 1);
 
  return baseKey;
  }

src/libraries/System.Data.Common/src/System/Data/DataTable.cs

@@ -6508,7 +6508,7 @@ internal void ReadXmlSchema(XmlReader? reader, bool denyResolving)
  {
  CurrentTableNamespace = CurrentTableFullName.Substring(0, nsSeperator);
  }
- string CurrentTableName = CurrentTableFullName.Substring(nsSeperator + 1, CurrentTableFullName.Length - nsSeperator - 1);
+ string CurrentTableName = CurrentTableFullName.Substring(nsSeperator + 1);
 
  currentTable = ds.Tables[CurrentTableName, CurrentTableNamespace];
  }

src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/DiagnosticSourceEventSource.cs

@@ -755,13 +755,13 @@ internal static void AddNewActivitySourceTransform(string filterAndPayloadSpec,
  {
  activitySourceName = entry.Slice(0, eventNameIndex).Trim();
 
- ReadOnlySpan<char> suffixPart = entry.Slice(eventNameIndex + 1, entry.Length - eventNameIndex - 1).Trim();
+ ReadOnlySpan<char> suffixPart = entry.Slice(eventNameIndex + 1).Trim();
  int samplingResultIndex = suffixPart.IndexOf('-');
  if (samplingResultIndex >= 0)
  {
  // We have the format "[AS]SourceName/[EventName]-[SamplingResult]
  eventName = suffixPart.Slice(0, samplingResultIndex).Trim();
- suffixPart = suffixPart.Slice(samplingResultIndex + 1, suffixPart.Length - samplingResultIndex - 1).Trim();
+ suffixPart = suffixPart.Slice(samplingResultIndex + 1).Trim();
 
  if (suffixPart.Length > 0)
  {

src/libraries/System.DirectoryServices/src/System/DirectoryServices/ActiveDirectory/Utils.cs

@@ -606,7 +606,7 @@ internal static void GetDomainAndUsername(DirectoryContext context, out string?
  if ((index = tmpUsername.IndexOf('\\')) != -1)
  {
  domain = tmpUsername.Substring(0, index);
- username = tmpUsername.Substring(index + 1, tmpUsername.Length - index - 1);
+ username = tmpUsername.Substring(index + 1);
  }
  else
  {

src/libraries/System.Drawing.Common/src/System/Drawing/FontConverter.cs

@@ -153,7 +153,7 @@ public override bool CanConvertTo(ITypeDescriptorContext? context, [NotNullWhen(
  if (styleIndex != -1)
  {
  // style found.
- style = font.Substring(styleIndex, font.Length - styleIndex);
+ style = font.Substring(styleIndex);
 
  // Get the mid-substring containing the size information.
  sizeStr = font.Substring(nameIndex + 1, styleIndex - nameIndex - 1);

src/libraries/System.IO.Compression/src/System/IO/Compression/DeflateManaged/InflaterManaged.cs

@@ -124,7 +124,7 @@ public int Inflate(Span<byte> bytes)
  }
  if (copied > 0)
  {
- bytes = bytes.Slice(copied, bytes.Length - copied);
+ bytes = bytes.Slice(copied);
  count += copied;
  }
 

src/libraries/System.IO.Packaging/src/System/IO/Packaging/PartBasedPackageProperties.cs

@@ -623,7 +623,7 @@ internal static void ValidateXsiType(XmlReader reader, object ns, string name)
  // The namespace of the prefix (string before ":") matches "ns"
  // The name (string after ":") matches "name"
  if (!object.ReferenceEquals(ns, reader.LookupNamespace(typeValue.Substring(0, index)))
- || string.CompareOrdinal(name, typeValue.Substring(index + 1, typeValue.Length - index - 1)) != 0)
+ || string.CompareOrdinal(name, typeValue.Substring(index + 1)) != 0)
  {
  throw new XmlException(SR.Format(SR.UnknownDCDateTimeXsiType, reader.Name),
  null, ((IXmlLineInfo)reader).LineNumber, ((IXmlLineInfo)reader).LinePosition);

src/libraries/System.Management/src/System/Management/ManagementDateTime.cs

@@ -255,7 +255,7 @@ public static string ToDmtfDateTime(DateTime date)
  else
  {
  string strTemp = OffsetMins.ToString(frmInt32);
- UtcString = "-" + strTemp.Substring(1, strTemp.Length - 1).PadLeft(3, '0');
+ UtcString = "-" + strTemp.Substring(1).PadLeft(3, '0');
  }
 
  string dmtfDateTime = date.Year.ToString(frmInt32).PadLeft(4, '0');

src/libraries/System.Management/src/System/Management/WMIGenerator.cs

@@ -825,7 +825,7 @@ private string ResolveCollision(string inString, bool bCheckthisFirst)
  if (strTemp.Length > 0)
  {
  string strFirstChar = strTemp.Substring(0, 1).ToUpperInvariant();
- strTemp = strFirstChar + strTemp.Substring(1, strTemp.Length - 1);
+ strTemp = strFirstChar + strTemp.Substring(1);
  }
 
  return strTemp;
@@ -7142,7 +7142,7 @@ private void AddToDMTFDateTimeFunction()
  else
  {
  string strTemp = OffsetMins.ToString();
- UtcString = "-" + strTemp.Substring(1, strTemp.Length-1).PadLeft(3,'0');
+ UtcString = "-" + strTemp.Substring(1).PadLeft(3,'0');
  }
  */
 

src/libraries/System.Net.Http/src/System/Net/Http/Headers/ContentDispositionHeaderValue.cs

@@ -518,7 +518,7 @@ private static bool TryDecode5987(string input, out string? output)
  }
 
  string encodingString = input.Substring(0, quoteIndex);
- string dataString = input.Substring(lastQuoteIndex + 1, input.Length - (lastQuoteIndex + 1));
+ string dataString = input.Substring(lastQuoteIndex + 1);
 
  StringBuilder decoded = new StringBuilder();
  try

src/libraries/System.Net.Requests/src/System/Net/FtpControlStream.cs

@@ -770,7 +770,7 @@ private static void GetPathInfo(GetPathOption pathOption,
  else
  {
  directory = path.Substring(0, index + 1);
- filename = path.Substring(index + 1, path.Length - (index + 1));
+ filename = path.Substring(index + 1);
  }
 
  // strip off trailing '/' on directory if present

src/libraries/System.Net.Requests/src/System/Net/FtpWebRequest.cs

@@ -510,7 +510,7 @@ internal FtpWebRequest(Uri uri)
  {
  username = Uri.UnescapeDataString(userInfo.Substring(0, index));
  index++; // skip ':'
- password = Uri.UnescapeDataString(userInfo.Substring(index, userInfo.Length - index));
+ password = Uri.UnescapeDataString(userInfo.Substring(index));
  }
  networkCredential = new NetworkCredential(username, password);
  }

src/libraries/System.Net.WebSockets/src/System/Net/WebSockets/ManagedWebSocket.cs

@@ -1361,7 +1361,7 @@ private async ValueTask EnsureBufferContainsAsync(int minimumRequiredBytes, Canc
  // While we don't have enough data, read more.
  while (_receiveBufferCount < minimumRequiredBytes)
  {
- int numRead = await _stream.ReadAsync(_receiveBuffer.Slice(_receiveBufferCount, _receiveBuffer.Length - _receiveBufferCount), cancellationToken).ConfigureAwait(false);
+ int numRead = await _stream.ReadAsync(_receiveBuffer.Slice(_receiveBufferCount), cancellationToken).ConfigureAwait(false);
  Debug.Assert(numRead >= 0, $"Expected non-negative bytes read, got {numRead}");
  if (numRead <= 0)
  {

src/libraries/System.Private.CoreLib/src/System/IO/Path.cs

@@ -243,7 +243,7 @@ public static ReadOnlySpan<char> GetFileName(ReadOnlySpan<char> path)
  for (int i = path.Length; --i >= 0;)
  {
  if (i < root || PathInternal.IsDirectorySeparator(path[i]))
- return path.Slice(i + 1, path.Length - i - 1);
+ return path.Slice(i + 1);
  }
 
  return path;

src/libraries/System.Private.Xml.Linq/src/System/Xml/Linq/XNodeReader.cs

@@ -1152,7 +1152,7 @@ private static void GetNameInAttributeScope(string? qualifiedName, XElement e, o
  XNamespace? ns = e.GetNamespaceOfPrefix(qualifiedName.Substring(0, i));
  if (ns != null)
  {
- localName = qualifiedName.Substring(i + 1, qualifiedName.Length - i - 1);
+ localName = qualifiedName.Substring(i + 1);
  namespaceName = ns.NamespaceName;
  return;
  }

src/libraries/System.Private.Xml/src/System/Xml/Schema/XmlSchemaDataType.cs

@@ -253,7 +253,7 @@ internal static string XdrCanonizeUri(string uri, XmlNameTable nameTable, Schema
 
  if (convert)
  {
- canonicalUri = nameTable.Add(string.Concat(uri.AsSpan(0, offset), uri.Substring(offset, uri.Length - offset).ToUpperInvariant()));
+ canonicalUri = nameTable.Add(string.Concat(uri.AsSpan(0, offset), uri.Substring(offset).ToUpperInvariant()));
  }
  else
  {

src/libraries/System.Private.Xml/src/System/Xml/ValidateNames.cs

@@ -626,7 +626,7 @@ internal static void SplitQName(string name, out string prefix, out string lname
  {
  prefix = name.Substring(0, colonPos);
  colonPos++; // move after colon
- lname = name.Substring(colonPos, name.Length - colonPos);
+ lname = name.Substring(colonPos);
  }
  }
  }

src/libraries/System.Security.Cryptography/src/System/Security/Cryptography/XmlKeyHelper.cs

@@ -117,7 +117,7 @@ internal static void WriteCryptoBinary(string name, int value, StringBuilder bui
  start++;
  }
 
- WriteCryptoBinary(name, valBuf.Slice(start, valBuf.Length - start), builder);
+ WriteCryptoBinary(name, valBuf.Slice(start), builder);
  }
 
  internal static void WriteCryptoBinary(string name, ReadOnlySpan<byte> value, StringBuilder builder)

src/libraries/System.Speech/src/Internal/ObjectToken/RegistryDataKey.cs

@@ -470,7 +470,7 @@ private static string GetFirstKeyAndParseRemainder(ref string registryPath)
  if (index >= 0)
  {
  firstKey = registryPath.Substring(0, index);
- registryPath = registryPath.Substring(index + 1, registryPath.Length - index - 1);
+ registryPath = registryPath.Substring(index + 1);
  }
  else
  {

src/libraries/System.Speech/src/Recognition/RecognizerBase.cs

@@ -1440,7 +1440,7 @@ private void LoadSapiDictationGrammar(SapiGrammar sapiGrammar, Uri uri, string r
  // - Modify SAPI so LoadCmdFromFile works with dictation Uris.
  // - Modify the engine and use a regular grammar with a special ruleref to dictation.
  // - Call back to the Grammar and let it manage the loading activation.
- string topicName = string.IsNullOrEmpty(uri.Fragment) ? null : uri.Fragment.Substring(1, uri.Fragment.Length - 1);
+ string topicName = string.IsNullOrEmpty(uri.Fragment) ? null : uri.Fragment.Substring(1);
  sapiGrammar.LoadDictation(topicName, SPLOADOPTIONS.SPLO_STATIC);
  }
  else

src/libraries/System.Text.RegularExpressions/src/System/Text/RegularExpressions/Regex.Split.cs

@@ -112,7 +112,7 @@ private static string[] Split(Regex regex, string input, int count, int startat)
  return new[] { input };
  }
 
- state.results.Add(input.Substring(state.prevat, input.Length - state.prevat));
+ state.results.Add(input.Substring(state.prevat));
  }
  else
  {

src/libraries/System.Text.RegularExpressions/src/System/Text/RegularExpressions/RegexReplacement.cs

@@ -228,7 +228,7 @@ public string Replace(Regex regex, string input, int count, int startat)
  return input;
  }
 
- state.segments.Add(state.inputMemory.Slice(state.prevat, input.Length - state.prevat));
+ state.segments.Add(state.inputMemory.Slice(state.prevat));
  }
  else
  {