Skip to content

Commit

Permalink
[wasm] Use Helix's retry mechanism to re-run debugger tests on CI if …
Browse files Browse the repository at this point in the history
….. (#78357)

.. they failed while waiting for the browser to launch.

Related: https://github.com/dotnet/arcade/tree/main/src/Microsoft.DotNet.Helix/Sdk#test-retry

Fixes #76528
  • Loading branch information
radical authored Nov 16, 2022
1 parent e398ba2 commit 7077690
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 2 additions & 1 deletion eng/test-configuration.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"defaultOnFailure": "fail",
"localRerunCount": 2,
"retryOnRules": [
{ "testAssembly": { "wildcard": "System.Net.*" } }
{ "testAssembly": { "wildcard": "System.Net.*" } },
{ "failureMessage": { "wildcard": "Timed out after * waiting for the browser to be ready" } }
]
}
2 changes: 2 additions & 0 deletions src/mono/wasm/debugger/DebuggerTestSuite/WasmHostProvider.cs
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,8 @@ protected ProcessStartInfo GetProcessStartInfo(string browserPath, string argume
}

// FIXME: use custom exception types
// Note: this message string is used in eng/test-configuration.json for triggering
// test retries
throw new IOException($"{messagePrefix} Timed out after {hostReadyTimeoutMs/1000}s waiting for the browser to be ready: {psi.FileName}");

void ProcessOutput(string prefix, string? msg)
Expand Down

0 comments on commit 7077690

Please sign in to comment.