Skip to content

Commit

Permalink
Upgrade superpmi benchmarks to 9.0 (#95372)
Browse files Browse the repository at this point in the history
* Upgrade to net9

* REVERT: comment other collections

* Revert "REVERT: comment other collections"

This reverts commit 2c4dae9.
  • Loading branch information
kunalspathak authored Nov 29, 2023
1 parent b190ea8 commit 7543b05
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/coreclr/scripts/superpmi_aspnet.py
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ def remove_readonly(func, path, _):
crank_arguments = ["--config", configFile,
"--profile", benchmark_machine,
"--scenario", scenario,
"--application.framework", "net8.0",
"--application.framework", "net9.0",
"--application.channel", "edge",
"--application.sdkVersion", "latest",
"--application.environmentVariables", "DOTNET_JitName=" + spminame,
Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/scripts/superpmi_benchmarks.py
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ def build_and_run(coreclr_args, output_mch_name):

run_command(
[dotnet_exe, "build", project_file, "--configuration", "Release",
"--framework", "net8.0", "--no-restore", "/p:NuGetPackageRoot=" + artifacts_packages_directory,
"--framework", "net9.0", "--no-restore", "/p:NuGetPackageRoot=" + artifacts_packages_directory,
"-o", artifacts_directory], _exit_on_fail=True)

# This is specifically for PowerShell.Benchmarks.
Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/scripts/superpmi_collect_setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,7 @@ def setup_benchmark(workitem_directory, arch):
# have not published yet. As a result, we hit errors of "dotnet restore". As a workaround, hard code the
# working version until we move to ".NET 8" in the script.
run_command(
get_python_name() + [dotnet_install_script, "install", "--channels", "8.0-preview", "--architecture", arch, "--install-dir",
get_python_name() + [dotnet_install_script, "install", "--channels", "9.0", "--architecture", arch, "--install-dir",
dotnet_directory, "--verbose"])


Expand Down

0 comments on commit 7543b05

Please sign in to comment.