Skip to content

Commit

Permalink
Working with StressLogAnalyzer I found yet another issue where we are…
Browse files Browse the repository at this point in the history
… missing an initialization when re-running the analysis - when you add a format string to look for via the -f option, and then later remove it, it's not actually removed, but is still found. (#74491)

 missing an initialization when re-running the analysis - when you add a format string to look for via the -f option, and then later remove it, it's not actually removed, but is still found.

The fix is simply to clear the s_interestingStringTable above the fixed entries.
  • Loading branch information
PeterSolMS authored Aug 25, 2022
1 parent 3eccadf commit 79e3cd0
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/coreclr/tools/StressLogAnalyzer/StressLogPlugin.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1227,6 +1227,10 @@ int ProcessStressLog(void* baseAddress, int argc, char* argv[])
s_fPrintFormatStrings = false;
s_showAllMessages = false;
s_maxHeapNumberSeen = -1;
for (int i = IS_INTERESTING; i < s_interestingStringCount; i++)
{
s_interestingStringTable[i] = nullptr;
}
s_interestingStringCount = IS_INTERESTING;
s_levelFilterCount = 0;
s_gcFilterStart = 0;
Expand Down

0 comments on commit 79e3cd0

Please sign in to comment.