Test Cleanup (#87450)

dotnet · Jun 13, 2023 · 861119c · 861119c
1 parent ff02a1f
commit 861119c
Showing 1 changed file with 3 additions and 8 deletions.
diff --git a/src/libraries/System.Globalization/tests/CultureInfo/CultureInfoCtor.cs b/src/libraries/System.Globalization/tests/CultureInfo/CultureInfoCtor.cs
@@ -441,6 +441,8 @@ public void TestCreationWithTemporaryLCID(int lcid)
  Assert.NotEqual(lcid, new CultureInfo(lcid).LCID);
  }
 
+ private static bool NotWasmWithIcu => PlatformDetection.IsNotBrowser && PlatformDetection.IsIcuGlobalization;
+
  [InlineData("zh-TW-u-co-zhuyin", "zh-TW", "zh-TW_zhuyin")]
  [InlineData("de-DE-u-co-phonebk", "de-DE", "de-DE_phoneboo")]
  [InlineData("de-DE-u-co-phonebk-u-xx", "de-DE-u-xx", "de-DE-u-xx_phoneboo")]
@@ -449,7 +451,7 @@ public void TestCreationWithTemporaryLCID(int lcid)
  [InlineData("de-DE-u-co-phonebk-t-xx", "de-DE-t-xx", "de-DE-t-xx_phoneboo")]
  [InlineData("de-DE-u-co-phonebk-t-xx-u-yy", "de-DE-t-xx-u-yy", "de-DE-t-xx-u-yy_phoneboo")]
  [InlineData("de-DE", "de-DE", "de-DE")]
- [ConditionalTheory(typeof(PlatformDetection), nameof(PlatformDetection.IsIcuGlobalization))]
+ [ConditionalTheory(nameof(NotWasmWithIcu))]
  public void TestCreationWithMangledSortName(string cultureName, string expectedCultureName, string expectedSortName)
  {
  CultureInfo ci = CultureInfo.GetCultureInfo(cultureName);
@@ -458,13 +460,6 @@ public void TestCreationWithMangledSortName(string cultureName, string expectedC
  Assert.Equal(expectedSortName, ci.CompareInfo.Name);
  }
 
- [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsIcuGlobalization))]
- public void TestNeutralCultureWithCollationName()
- {
- Assert.Throws<CultureNotFoundException>(() => CultureInfo.GetCultureInfo("zh-u-co-zhuyin"));
- Assert.Throws<CultureNotFoundException>(() => CultureInfo.GetCultureInfo("de-u-co-phonebk"));
- }
-
  private static bool SupportRemoteExecutionWithIcu => RemoteExecutor.IsSupported && PlatformDetection.IsIcuGlobalization;
 
  [InlineData("xx-u-XX", "xx-u-xx")]