Remove CheckForOverflowUnderflow (#63825)

* Remove set false to CheckForOverflowUnderflow due to it is disabled by default * Use checked instead of CheckForOverflowUnderflow
dotnet · Jan 29, 2022 · 874d6a3 · 874d6a3 · Xyncgas · Jan 29, 2022
1 parent 8471eec
commit 874d6a3
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/src/libraries/Directory.Build.props b/src/libraries/Directory.Build.props
@@ -87,8 +87,6 @@
 
   <!-- Language configuration -->
   <PropertyGroup>
-    <!-- We decided to keep this disabled by default: https://github.com/dotnet/runtime/issues/15152 -->
-    <CheckForOverflowUnderflow>false</CheckForOverflowUnderflow>
     <GenFacadesIgnoreBuildAndRevisionMismatch>true</GenFacadesIgnoreBuildAndRevisionMismatch>
     <!-- Disable analyzers for tests and unsupported projects -->
     <RunAnalyzers Condition="'$(IsTestProject)' != 'true' and '$(IsSourceProject)' != 'true'">false</RunAnalyzers>

diff --git a/src/tests/JIT/Regression/Dev11/dev11_4421/Dev11_4421.cs b/src/tests/JIT/Regression/Dev11/dev11_4421/Dev11_4421.cs
@@ -10,8 +10,11 @@ private static int Main()
         int Var1, Temp;
         try
         {
-            for (Temp = int.MaxValue - 3; Temp <= int.MaxValue - 1; Temp++)
-                Var1 = (int)(2 + Temp);
+            checked
+            {
+                for (Temp = int.MaxValue - 3; Temp <= int.MaxValue - 1; Temp++)
+                    Var1 = (int)(2 + Temp);
+            }
         }
         catch (Exception ex)
         {

diff --git a/src/tests/JIT/Regression/Dev11/dev11_4421/Dev11_4421.csproj b/src/tests/JIT/Regression/Dev11/dev11_4421/Dev11_4421.csproj
@@ -5,7 +5,6 @@
   <PropertyGroup>
     <DebugType>PdbOnly</DebugType>
     <Optimize>True</Optimize>
-    <CheckForOverflowUnderflow>True</CheckForOverflowUnderflow>
   </PropertyGroup>
   <ItemGroup>
     <Compile Include="Dev11_4421.cs" />