Mark "push [mem]" candidates reg optional (#68641)

dotnet · May 9, 2022 · 95952a6 · 95952a6
1 parent e7f1655
commit 95952a6
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/src/coreclr/jit/lowerxarch.cpp b/src/coreclr/jit/lowerxarch.cpp
@@ -647,11 +647,17 @@ void Lowering::LowerPutArgStk(GenTreePutArgStk* putArgStk)
  MakeSrcContained(putArgStk, src);
  }
 #ifdef TARGET_X86
- else if ((genTypeSize(src) == TARGET_POINTER_SIZE) && IsContainableMemoryOp(src) &&
- IsSafeToContainMem(putArgStk, src))
+ else if ((genTypeSize(src) == TARGET_POINTER_SIZE) && IsSafeToContainMem(putArgStk, src))
  {
- // Contain for "push [mem]".
- MakeSrcContained(putArgStk, src);
+ // We can use "src" directly from memory with "push [mem]".
+ if (IsContainableMemoryOp(src))
+ {
+ MakeSrcContained(putArgStk, src);
+ }
+ else
+ {
+ src->SetRegOptional();
+ }
  }
 #endif // TARGET_X86
 }