fix test bug

dotnet · Feb 1, 2021 · a6cf539 · a6cf539
1 parent e4f2d69
commit a6cf539
Showing 1 changed file with 12 additions and 9 deletions.
diff --git a/src/libraries/System.Diagnostics.Process/tests/ProcessTests.Unix.cs b/src/libraries/System.Diagnostics.Process/tests/ProcessTests.Unix.cs
@@ -4,6 +4,7 @@
 using System.Collections;
 using System.Collections.Generic;
 using System.ComponentModel;
+using System.Globalization;
 using System.IO;
 using System.Linq;
 using System.Reflection;
@@ -804,20 +805,19 @@ public void TestProcessRecycledPid()
 
  [PlatformSpecific(TestPlatforms.AnyUnix)]
  [ConditionalTheory(typeof(RemoteExecutor), nameof(RemoteExecutor.IsSupported))]
- [InlineData("/dev/stdin")]
- [InlineData("/dev/stdout")]
- [InlineData("/dev/stderr")]
- public void ChildProcessRedirectedIO_FilePathOpenShouldSucceed(string filename)
+ [InlineData("/dev/stdin", O_RDONLY)]
+ [InlineData("/dev/stdout", O_WRONLY)]
+ [InlineData("/dev/stderr", O_WRONLY)]
+ public void ChildProcessRedirectedIO_FilePathOpenShouldSucceed(string filename, int flags)
  {
  var options = new RemoteInvokeOptions { StartInfo = new ProcessStartInfo { RedirectStandardOutput = true, RedirectStandardInput = true, RedirectStandardError = true }};
- using (RemoteInvokeHandle handle = RemoteExecutor.Invoke(ExecuteChildProcess, filename, options))
+ using (RemoteInvokeHandle handle = RemoteExecutor.Invoke(ExecuteChildProcess, filename, flags.ToString(CultureInfo.InvariantCulture), options))
  { }
 
- static void ExecuteChildProcess(string filename)
+ static void ExecuteChildProcess(string filename, string flags)
  {
- int flags = filename == "/dev/stdin" ? /* O_WRONLY */ 1 : /* O_RDONLY */ 0;
- int result = open(filename, flags);
- Assert.True(result >= 0);
+ int result = open(filename, int.Parse(flags, CultureInfo.InvariantCulture));
+ Assert.True(result >= 0, $"failed to open file with {result} and errno {Marshal.GetLastWin32Error()}.");
  }
  }
 
@@ -963,6 +963,9 @@ private static unsafe HashSet<uint> GetGroups()
  [DllImport("libc", SetLastError = true)]
  private static extern int open(string pathname, int flags);
 
+ private const int O_RDONLY = 0;
+ private const int O_WRONLY = 1;
+
  private static readonly string[] s_allowedProgramsToRun = new string[] { "xdg-open", "gnome-open", "kfmclient" };
 
  private string WriteScriptFile(string directory, string name, int returnValue)