Fix superpmi collect failure for crossgen2 on linux x64 and windows x…

…86 (#104181)

* Fix superpmi collect failure for crossgen2 on linux x64.

* Remove .NET SDK and keep Dotnet.Helix SDK only.

* Ignore ilc.exe in partition 0 for a quick fix to libraries crossgen2 windows x86 failure becasue ilc.exe in partition 0 does not have any managed assemblies in it.

* Address feedback to insert ilc.exe in the ignore list in a sorted order.

eng/pipelines/coreclr/templates/run-superpmi-collect-job.yml

@@ -146,6 +146,7 @@ jobs:
         ProjectFile: 'superpmi-collect.proj'
         BuildConfig: ${{ parameters.buildConfig }}
         osGroup: ${{ parameters.osGroup }}
+        archType: ${{ parameters.archType }}
         InputArtifacts: '$(InputArtifacts)'
         CollectionType: '$(CollectionType)'
         CollectionName: '$(CollectionName)'

eng/pipelines/coreclr/templates/superpmi-send-to-helix.yml

@@ -19,6 +19,8 @@ parameters:
   condition: succeeded()                 # optional -- condition for step to execute; defaults to succeeded()
   continueOnError: false                 # optional -- determines whether to continue the build if the step errors; defaults to false
   BuildConfig: 'checked'                 # optional -- Mostly, superpmi will be run on checked builds
+  osGroup: ''                            # required -- the OS group to run the tests on; defaults to the OS group of the build
+  archType: ''                           # required -- the architecture to run the tests on; defaults to the architecture of the build
   InputArtifacts: ''
   CollectionType: ''
   CollectionName: ''
@@ -33,6 +35,8 @@ steps:
     condition: ${{ parameters.condition }}
     shouldContinueOnError: ${{ parameters.continueOnError }}
     environment:
+      TargetOS: ${{ parameters.osGroup }}
+      TargetArchitecture: ${{ parameters.archType }}
       MchFileTag: $(MchFileTag)
       BuildConfig:  ${{ parameters.BuildConfig }}
       InputArtifacts: ${{ parameters.InputArtifacts }}
@@ -53,4 +57,4 @@ steps:
       EnableXUnitReporter: ${{ parameters.EnableXUnitReporter }}
       WaitForWorkItemCompletion: ${{ parameters.WaitForWorkItemCompletion }}
       Creator: ${{ parameters.Creator }}
-      SYSTEM_ACCESSTOKEN: $(System.AccessToken)
+      SYSTEM_ACCESSTOKEN: $(System.AccessToken)

src/coreclr/scripts/superpmi-collect.proj

@@ -165,6 +165,20 @@
   </ItemGroup>
   -->
 
+  <PropertyGroup Condition=" '$(CollectionType)' == 'crossgen2' ">
+    <TargetOSSpec>$(TargetOS)$(TargetOSSubgroup)</TargetOSSpec>
+    <HelixRuntimeRid Condition="'$(TargetOSSpec)' == 'windows'">win-$(TargetArchitecture)</HelixRuntimeRid>
+    <HelixRuntimeRid Condition="'$(TargetOSSpec)' == 'osx'">osx-$(TargetArchitecture)</HelixRuntimeRid>
+    <HelixRuntimeRid Condition="'$(TargetOSSpec)' == 'linux'">linux-$(TargetArchitecture)</HelixRuntimeRid>
+  </PropertyGroup>
+
+  <PropertyGroup Condition=" '$(CollectionType)' == 'crossgen2' ">
+    <IncludeDotNetCli>true</IncludeDotNetCli>
+    <DotNetCliPackageType>runtime</DotNetCliPackageType>
+    <DotNetCliVersion>$(BundledNETCoreAppPackageVersion)</DotNetCliVersion>
+    <DotNetCliRuntime>$(HelixRuntimeRid)</DotNetCliRuntime>
+  </PropertyGroup>
+
   <PropertyGroup>
     <HelixPreCommands>@(HelixPreCommand)</HelixPreCommands>
     <HelixPostCommands>@(HelixPostCommand)</HelixPostCommands>

src/coreclr/scripts/superpmi_collect_setup.py

@@ -150,6 +150,7 @@
     "e_sqlite3.dll",
     "FileCheck.exe",
     "ilasm.exe",
+    "ilc.exe",
     "ildasm.exe",
     "jitinterface_arm.dll",
     "jitinterface_arm64.dll",
@@ -453,7 +454,7 @@ def main(main_args):
     ci = True
 
     # Determine the Helix queue name to use when running jobs.
-    # Note that we run in the 'internal', not 'public', instance, so we must use 'internal' queues.
+    # Note that we run in the 'internal', not 'public', instance, so we must use 'internal' queues defined in helix-queues-setup.yml.
     if platform_name == "windows":
         helix_queue = "Windows.11.Arm64" if arch == "arm64" else "Windows.10.Amd64.X86.Rt"
     elif platform_name == "linux":