Skip to content

Commit

Permalink
commenting out an assert that could be triggered on Win7 (#57524)
Browse files Browse the repository at this point in the history
  • Loading branch information
VSadov authored Aug 17, 2021
1 parent 3e3b00c commit f7cd0c6
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/coreclr/vm/threadsuspend.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1985,7 +1985,9 @@ CONTEXT* AllocateOSContextHelper(BYTE** contextBuffer)
pfnInitializeContext2(NULL, context, NULL, &contextSize, xStateCompactionMask) :
InitializeContext(NULL, context, NULL, &contextSize);

_ASSERTE(!success && GetLastError() == ERROR_INSUFFICIENT_BUFFER);
// The following assert is valid, but gets triggered in some Win7 runs with no impact on functionality.
// commenting this out to reduce noise, as long as Win7 is supported.
// _ASSERTE(!success && GetLastError() == ERROR_INSUFFICIENT_BUFFER);

// So now allocate a buffer of that size and call InitializeContext again
BYTE* buffer = new (nothrow)BYTE[contextSize];
Expand Down

0 comments on commit f7cd0c6

Please sign in to comment.