Dispose XMLReader after using in Xml/Utils.cs (#103236)

They are IDisposables and should be Dispose()d after being used to avoid resource leaks.
dotnet · Jun 13, 2024 · f821a7d · f821a7d
1 parent 3f9a441
commit f821a7d
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/libraries/System.Security.Cryptography.Xml/src/System/Security/Cryptography/Xml/Utils.cs b/src/libraries/System.Security.Cryptography.Xml/src/System/Security/Cryptography/Xml/Utils.cs
@@ -212,7 +212,7 @@ internal static XmlDocument PreProcessDocumentInput(XmlDocument document, XmlRes
                 settings.DtdProcessing = DtdProcessing.Parse;
                 settings.MaxCharactersFromEntities = MaxCharactersFromEntities;
                 settings.MaxCharactersInDocument = MaxCharactersInDocument;
-                XmlReader reader = XmlReader.Create(stringReader, settings, baseUri);
+                using XmlReader reader = XmlReader.Create(stringReader, settings, baseUri);
                 doc.Load(reader);
             }
             return doc;
@@ -235,7 +235,7 @@ internal static XmlDocument PreProcessElementInput(XmlElement elem, XmlResolver
                 settings.DtdProcessing = DtdProcessing.Parse;
                 settings.MaxCharactersFromEntities = MaxCharactersFromEntities;
                 settings.MaxCharactersInDocument = MaxCharactersInDocument;
-                XmlReader reader = XmlReader.Create(stringReader, settings, baseUri);
+                using XmlReader reader = XmlReader.Create(stringReader, settings, baseUri);
                 doc.Load(reader);
             }
             return doc;