Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI doesn't build net9.0 targets in source generators. #100346

Closed
eiriktsarpalis opened this issue Mar 27, 2024 · 3 comments · Fixed by #105247
Closed

CI doesn't build net9.0 targets in source generators. #100346

eiriktsarpalis opened this issue Mar 27, 2024 · 3 comments · Fixed by #105247
Assignees
@ViktorHofer
Labels
area-Infrastructure-libraries
Milestone
9.0.0

Comments

@eiriktsarpalis
Copy link
Member

A while back we added net9.0 targets to the source generator projects so that they support nullability annotations. These aren't being used by the product but help with local development. We discovered with #100345 that these targets aren't being built by CI, so it's easy for them to be broken.

cc @ViktorHofer
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Mar 27, 2024
@ViktorHofer ViktorHofer added this to the 9.0.0 milestone Mar 27, 2024
@huoyaoyuan
Copy link
Member

My local development environment lacks SG in VS currently, which is annoying when developing interop-heavy code. Sounds related to this?

@ericstj
Copy link
Member

ericstj commented Mar 27, 2024

Shouldn't be. These SG builds aren't meant to be run anywhere. Just built to validate nullable annotations.

If SG's aren't working in your dev environment it's probably because you're using a VS that's older than the compiler toolset we're using and they are failing to load. Make sure you're on a preview VS with the 9.0 preview SDK installed.

@jeffschwMSFT jeffschwMSFT removed the untriaged New issue has not been triaged by the area owner label May 3, 2024
ViktorHofer added a commit that referenced this issue Jul 22, 2024
@ViktorHofer
Build .NETCoreApp source gens in allconfigurations build
057fb79 
Fixes #100346
@ViktorHofer ViktorHofer mentioned this issue Jul 22, 2024
Merged
@ViktorHofer ViktorHofer self-assigned this Jul 22, 2024
ViktorHofer added a commit that referenced this issue Jul 23, 2024
@ViktorHofer @mmitche
Build .NETCoreApp source gens in allconfigurations build (#105247)
e2a3511 
* Build .NETCoreApp source gens in allconfigurations build

Fixes #100346

* Update RegexGenerator.Emitter.cs

---------

Co-authored-by: Matt Mitchell <mmitche@microsoft.com>
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ViktorHofer ViktorHofer

Labels
area-Infrastructure-libraries
Projects
None yet
Milestone
9.0.0
Development

Successfully merging a pull request may close this issue.

Build .NETCoreApp source gens in allconfigurations build dotnet/runtime
5 participants
@eiriktsarpalis @huoyaoyuan @ViktorHofer @ericstj @jeffschwMSFT