Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mono] Build fails with libcdacreader.so missing from manifest #103486

Closed
LoopedBard3 opened this issue Jun 14, 2024 · 5 comments · Fixed by #103488
Closed

[Mono] Build fails with libcdacreader.so missing from manifest #103486

LoopedBard3 opened this issue Jun 14, 2024 · 5 comments · Fixed by #103488
Labels
area-Infrastructure-mono in-pr There is an active PR which will close this issue when it is merged

Comments

@LoopedBard3
Copy link
Member

Description

When attempting to build Mono for linux-x64 using the build command build.sh -ci -arch x64 -os linux -cross -s mono+clr.iltools+clr.hosts+libs+host+packs -c Release, the build fails with this error:

/__w/1/s/.packages/microsoft.dotnet.sharedframework.sdk/9.0.0-beta.24311.10/targets/sharedfx.targets(296,5): error : The following files are missing entries in the templated manifest: [/__w/1/s/src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Runtime.sfxproj]
/__w/1/s/.packages/microsoft.dotnet.sharedframework.sdk/9.0.0-beta.24311.10/targets/sharedfx.targets(296,5): error : libcdacreader.so. Add these file names with extensions to the 'PlatformManifestFileEntry' item group for the runtime pack and corresponding ref pack to include them in the platform manifest. [/__w/1/s/src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Runtime.sfxproj]

Example pipeline with the failure: https://dev.azure.com/dnceng/internal/_build/results?buildId=2472669&view=results
This seems like a similar error as was hit here: #67829.

Reproduction Steps

Clone the runtime repo and build with build.sh -ci -arch x64 -os linux -cross -s mono+clr.iltools+clr.hosts+libs+host+packs -c Release using the build.sh.

Expected behavior

Build succeeds

Actual behavior

Build fails with:

/__w/1/s/.packages/microsoft.dotnet.sharedframework.sdk/9.0.0-beta.24311.10/targets/sharedfx.targets(296,5): error : The following files are missing entries in the templated manifest: [/__w/1/s/src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Runtime.sfxproj]
/__w/1/s/.packages/microsoft.dotnet.sharedframework.sdk/9.0.0-beta.24311.10/targets/sharedfx.targets(296,5): error : libcdacreader.so. Add these file names with extensions to the 'PlatformManifestFileEntry' item group for the runtime pack and corresponding ref pack to include them in the platform manifest. [/__w/1/s/src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Runtime.sfxproj]

Regression?

This broke sometime Wednesday the 12th, with the diff between our last working and first broken build being: bb2a99b...eb8f54d

Known Workarounds

None

Configuration

Build is completed with the latest runtime targeting linux-x64

Other information

No response

@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Jun 14, 2024
Copy link
Contributor

Tagging subscribers to this area: @directhex, @matouskozak
See info in area-owners.md if you want to be subscribed.

@lambdageek
Copy link
Member

/cc @am11 @MichalStrehovsky

@am11
Copy link
Member

am11 commented Jun 14, 2024

#103488 should fix it.

@am11 am11 added in-pr There is an active PR which will close this issue when it is merged and removed untriaged New issue has not been triaged by the area owner labels Jun 14, 2024
@lambdageek
Copy link
Member

I don't think we want to add cdacreader to the manifest - we don't want to ship it yet since it's not signed like the other diagnostic libraries (and we don't check its signature even if it were signed) #100946 (comment)

@am11
Copy link
Member

am11 commented Jun 14, 2024

Entries are now there for exclusion, not inclusion.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure-mono in-pr There is an active PR which will close this issue when it is merged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants