Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

superpmi-replay failing with Assertion failed 'emitCurIG != emitPrologIG' #104570

Closed
jakobbotsch opened this issue Jul 8, 2024 · 2 comments · Fixed by #104593
Closed

superpmi-replay failing with Assertion failed 'emitCurIG != emitPrologIG' #104570

jakobbotsch opened this issue Jul 8, 2024 · 2 comments · Fixed by #104593
Assignees
@jakobbotsch
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI blocking-clean-ci-optional Blocking optional rolling runs
Milestone
9.0.0

Comments

@jakobbotsch
Copy link
Member

superpmi-replay jobs are failing with this assert

[04:30:25] ISSUE: <ASSERT> #186407 D:\a\_work\1\s\src\coreclr\jit\emit.cpp (9672) - Assertion failed 'emitCurIG != emitPrologIG' in 'System.Numerics.Tensors.TensorPrimitives:<Aggregate>g__Vectorized512|67_3[ulong,System.Numerics.Tensors.TensorPrimitives+SquaredOperator`1[ulong],System.Numerics.Tensors.TensorPrimitives+AddOperator`1[ulong]](byref,ulong):ulong' during 'Generate code' (IL size 1149; hash 0x6bc820e5; FullOpts)

Example pipeline run: https://dev.azure.com/dnceng-public/public/_build/results?buildId=733104&view=results
Example console log: https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-104554-merge-492afeb818194082b4/windows-x64-3/1/console.c2da1a33.log?helixlogtype=result
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 8, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Jul 8, 2024
@jakobbotsch jakobbotsch added blocking-clean-ci-optional Blocking optional rolling runs and removed untriaged New issue has not been triaged by the area owner labels Jul 8, 2024
@jakobbotsch
Copy link
Member Author

cc @dotnet/jit-contrib

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@amanasifkhalid amanasifkhalid mentioned this issue Jul 8, 2024
Merged
@jakobbotsch jakobbotsch mentioned this issue Jul 8, 2024
Merged
jakobbotsch added a commit to jakobbotsch/runtime that referenced this issue Jul 9, 2024
@jakobbotsch
JIT: Account for mixed-enregistered locals when zeroing without block…
95dc247 
…-init

Locals that are in registers at the beginning of a function do not need
to have their stack home zeroed. `genFnProlog` already skips these
locals when computing the range of bytes to zero; however,
`genZeroInitFrame` was not doing the same in the non-block init case,
which does not make use of the range computed by `genFnProlog`. This
could cause an unbounded amount of (unnecessary) codegen during
zero-initing, which is not legal to have in the prolog.

Fix dotnet#104570
@jakobbotsch jakobbotsch mentioned this issue Jul 9, 2024
Merged
@jakobbotsch jakobbotsch self-assigned this Jul 9, 2024
@jakobbotsch jakobbotsch added this to the 9.0.0 milestone Jul 9, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jakobbotsch jakobbotsch

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI blocking-clean-ci-optional Blocking optional rolling runs
Projects
None yet
Milestone
9.0.0
Development

Successfully merging a pull request may close this issue.

JIT: Account for mixed-enregistered locals when zeroing without block-init jakobbotsch/runtime
1 participant
@jakobbotsch