Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ILCompiler.Compiler.Tests.SwiftLoweringTests.VerifyLowering failing with preivew 6 #104765

Closed
am11 opened this issue Jul 11, 2024 · 2 comments · Fixed by #104843
Closed

ILCompiler.Compiler.Tests.SwiftLoweringTests.VerifyLowering failing with preivew 6 #104765

am11 opened this issue Jul 11, 2024 · 2 comments · Fixed by #104843
Assignees
Labels
area-NativeAOT-coreclr blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' Known Build Error Use this to report build issues in the .NET Helix tab
Milestone

Comments

@am11
Copy link
Member

am11 commented Jul 11, 2024

Build Information

Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=737461
Build error leg or test failing: ILCompiler.Compiler.Tests.SwiftLoweringTests.VerifyLowering
Pull request: #104696

Error Message

    Assert.Equal() Failure: Exception thrown during comparison
Expected: {CORINFO_TYPE_LONG: 0, CORINFO_TYPE_DOUBLE: 8, CORINFO_TYPE_LONG: 16, CORINFO_TYPE_SHORT: 24}
Actual:   {CORINFO_TYPE_LONG: 0, CORINFO_TYPE_DOUBLE: 8, CORINFO_TYPE_LONG: 16, CORINFO_TYPE_SHORT: 24}
---- System.NotSupportedException : Calling built-in Equals() or GetHashCode() on type marked as InlineArray is invalid.

   at ILCompiler.Compiler.Tests.SwiftLoweringTests.VerifyLowering(String typeName, EcmaType type, CORINFO_SWIFT_LOWERING expectedLowering) in /_/src/coreclr/tools/aot/ILCompiler.Compiler.Tests/SwiftLoweringTests.cs:line 106
at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
at System.Reflection.MethodBaseInvoker.InvokeDirectByRefWithFewArgs(Object obj, Span`1 copyOfArgs, BindingFlags invokeAttr)

----- Inner Stack Trace -----
at System.ValueType.CanCompareBitsOrUseFastGetHashCode(MethodTable* pMT)
at System.ValueType.Equals(Object obj)
at System.ValueType.Equals(Object obj)
{
  "ErrorMessage": "Calling built-in Equals() or GetHashCode() on type marked as InlineArray is invalid",
  "BuildRetry": false,
  "ExcludeConsoleLog": false
}

Known issue validation

Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=737461
Error message validated: [Calling built-in Equals() or GetHashCode() on type marked as InlineArray is invalid]
Result validation: ❌ Known issue did not match with the provided build.
Validation performed at: 7/11/2024 10:27:03 PM UTC

Report

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
0 0 0
@am11 am11 added blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' area-NativeAOT-coreclr Known Build Error Use this to report build issues in the .NET Helix tab labels Jul 11, 2024
Copy link
Contributor

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Jul 11, 2024
@MichalStrehovsky
Copy link
Member

Cc @jkoritzinsky, looks like the test is trying to compare two InlineArrays using the built-in valuetype equality. This just silently didn't work in the past but now it throws.

@MichalStrehovsky MichalStrehovsky added this to the 9.0.0 milestone Jul 12, 2024
@MichalStrehovsky MichalStrehovsky removed the untriaged New issue has not been triaged by the area owner label Jul 12, 2024
@jkoritzinsky jkoritzinsky self-assigned this Jul 12, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-NativeAOT-coreclr blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' Known Build Error Use this to report build issues in the .NET Helix tab
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants