Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacement for mono-symbolicate #106395

Open
thaystg opened this issue Aug 14, 2024 · 1 comment
Open

Replacement for mono-symbolicate #106395

thaystg opened this issue Aug 14, 2024 · 1 comment
Labels
area-Diagnostics-mono enhancement Product code improvement that does NOT require public API changes/additions
Milestone
10.0.0

Comments

@thaystg
Copy link
Member

thaystg commented Aug 14, 2024

We don't have a good solution for line numbers in stack traces in .NET 6+ for release apps.

https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1809586/
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Aug 14, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

@thaystg thaystg added enhancement Product code improvement that does NOT require public API changes/additions and removed untriaged New issue has not been triaged by the area owner labels Aug 14, 2024
@tommcdon tommcdon added this to the 10.0.0 milestone Aug 14, 2024
jonathanpeppers added a commit to jonathanpeppers/xamarin-android that referenced this issue Aug 19, 2024
@jonathanpeppers
[Xamarin.Android.Build.Tasks] remove $XAMARIN_BUILD_ID
69ef11a 
Fixes: dotnet#9212

`$XAMARIN_BUILD_ID` was a value that was only used by the
`mono-symbolicate` feature from Xamarin. In .NET 6+,
`mono-symbolicate` is not supported (and unfortunately, no
replacement yet):

* dotnet/runtime#106395

Likely, a new solution would use some new tool like `dotnet-symbol`,
which is able to locate symbol information based on existing
information inside managed `.dll`'s or even native libraries.

Remove `$XAMARIN_BUILD_ID`, in order to delete unused code, and
improve incremental build times mentioned in dotnet#9212.
@jonathanpeppers jonathanpeppers mentioned this issue Aug 19, 2024
Merged
dellis1972 pushed a commit to dotnet/android that referenced this issue Aug 20, 2024
@jonathanpeppers
[Xamarin.Android.Build.Tasks] remove $XAMARIN_BUILD_ID (#9223)
eb5455a 
* [Xamarin.Android.Build.Tasks] remove `$XAMARIN_BUILD_ID`

Fixes: #9212

`$XAMARIN_BUILD_ID` was a value that was only used by the
`mono-symbolicate` feature from Xamarin. In .NET 6+,
`mono-symbolicate` is not supported (and unfortunately, no
replacement yet):

* dotnet/runtime#106395

Likely, a new solution would use some new tool like `dotnet-symbol`,
which is able to locate symbol information based on existing
information inside managed `.dll`'s or even native libraries.

Remove `$XAMARIN_BUILD_ID`, in order to delete unused code, and
improve incremental build times mentioned in #9212.

* Fix GenerateJavaStubsAndAssembly test

`$XAMARIN_BUILD_ID` doesn't trigger `_CompileNativeAssemblySources` any longer

* Fix GenerateJavaStubsAndAssembly test, take 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-Diagnostics-mono enhancement Product code improvement that does NOT require public API changes/additions
Projects
None yet
Milestone
10.0.0
Development

No branches or pull requests
3 participants
@thaystg @jkotas @tommcdon