Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

superpmi-diffs pipeline fails on clean replay #106851

Closed
amanasifkhalid opened this issue Aug 23, 2024 · 1 comment · Fixed by #106859
Closed

superpmi-diffs pipeline fails on clean replay #106851

amanasifkhalid opened this issue Aug 23, 2024 · 1 comment · Fixed by #106859
Assignees
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI in-pr There is an active PR which will close this issue when it is merged
Milestone

Comments

@amanasifkhalid
Copy link
Member

Example run:

[00:41:11] Invoking: C:\h\w\A6510915\p\superpmi.exe -a -v ewi -f C:\h\w\A6510915\t\tmpt88238qu\benchmarks.run.linux.arm64.checked.mch_fail.mcl -details C:\h\w\A6510915\t\tmpt88238qu\benchmarks.run.linux.arm64.checked.mch_details.csv -target arm64 -jitoption force JitEnableNoWayAssert=1 -jitoption force JitNoForceFallback=1 -jitoption force JitAlignLoops=0 -jit2option force JitEnableNoWayAssert=1 -jit2option force JitNoForceFallback=1 -jit2option force JitAlignLoops=0 -p -failureLimit 100 C:\h\w\A6510915\p\base\checked\clrjit_universal_arm64_x64.dll C:\h\w\A6510915\p\diff\checked\clrjit_universal_arm64_x64.dll C:\h\w\A6510915\p\artifacts\spmi\mch\62865a69-7c84-4ba5-8636-a7dec55c05a7.linux.arm64\benchmarks.run.linux.arm64.checked.mch

[00:42:12] Clean SuperPMI diff (32851 contexts processed)

[00:42:12] Asm diffs summary:


Traceback (most recent call last):

  File "C:\h\w\A6510915\p\superpmi.py", line 5482, in <module>

    sys.exit(main(args))

  File "C:\h\w\A6510915\p\superpmi.py", line 5370, in main

    success = asm_diffs.replay_with_asm_diffs()

  File "C:\h\w\A6510915\p\superpmi.py", line 2552, in replay_with_asm_diffs

    summarizable_asm_diffs = self.create_summarizable_asm_diffs(asm_diffs)

  File "C:\h\w\A6510915\p\superpmi.py", line 2617, in create_summarizable_asm_diffs

    with open(jit_analyze_file, "r") as read_fh:

TypeError: expected str, bytes or os.PathLike object, not NoneType

This seems to have been introduced by #106759. cc @dotnet/jit-contrib @jakobbotsch

@amanasifkhalid amanasifkhalid added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Aug 23, 2024
@amanasifkhalid amanasifkhalid added this to the 10.0.0 milestone Aug 23, 2024
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@jakobbotsch jakobbotsch self-assigned this Aug 23, 2024
jakobbotsch added a commit to jakobbotsch/runtime that referenced this issue Aug 23, 2024
@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Aug 23, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 23, 2024
mikelle-rogers pushed a commit to mikelle-rogers/runtime that referenced this issue Dec 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI in-pr There is an active PR which will close this issue when it is merged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants