Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT: Assertion failed '!arg->OperIsPutArg()' during 'Lowering nodeinfo' #106876

Closed
jakobbotsch opened this issue Aug 23, 2024 · 2 comments · Fixed by #106954
Closed

JIT: Assertion failed '!arg->OperIsPutArg()' during 'Lowering nodeinfo' #106876

jakobbotsch opened this issue Aug 23, 2024 · 2 comments · Fixed by #106954
Assignees
@jakobbotsch
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI arm-sve Work related to arm64 SVE/SVE2 support in-pr There is an active PR which will close this issue when it is merged
Milestone
9.0.0

Comments

@jakobbotsch
Copy link
Member

Reduced repro is large so I've attached an SPMI collection that reproduces the problem on 269ea26.

I can take a look.

repro-33545.zip
@jakobbotsch jakobbotsch self-assigned this Aug 23, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Aug 23, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Aug 23, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@JulieLeeMSFT JulieLeeMSFT removed the untriaged New issue has not been triaged by the area owner label Aug 23, 2024
@JulieLeeMSFT JulieLeeMSFT added this to the 9.0.0 milestone Aug 23, 2024
@jakobbotsch jakobbotsch added the arm-sve Work related to arm64 SVE/SVE2 support label Aug 26, 2024
@jakobbotsch
Copy link
Member Author

This looks like a bug introduced in #105812. It lowers CndSel(AllTrue, op2, op3) into op2, but then proceeds to lower from op2. This will repeat lowering for some nodes.

jakobbotsch added a commit to jakobbotsch/runtime that referenced this issue Aug 26, 2024
@jakobbotsch
JIT: Fix CndSel(AllTrue, op2, op3) -> op2 "next" node return
99ae95f 
When lowering makes this transformation it should proceed lowering from
the original next node of the `CndSel`, not from `op2`. If we proceed
lowering from `op2` we will relower some nodes.

Fix dotnet#106876
@jakobbotsch jakobbotsch mentioned this issue Aug 26, 2024
Merged
@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Aug 26, 2024
github-actions bot pushed a commit that referenced this issue Aug 26, 2024
@jakobbotsch
JIT: Fix CndSel(AllTrue, op2, op3) -> op2 "next" node return
550da4d 
When lowering makes this transformation it should proceed lowering from
the original next node of the `CndSel`, not from `op2`. If we proceed
lowering from `op2` we will relower some nodes.

Fix #106876
jeffschwMSFT added a commit that referenced this issue Aug 27, 2024
@github-actions @jakobbotsch @jeffschwMSFT
JIT: Fix CndSel(AllTrue, op2, op3) -> op2 "next" node return (#106971)
8626a1b 
When lowering makes this transformation it should proceed lowering from
the original next node of the `CndSel`, not from `op2`. If we proceed
lowering from `op2` we will relower some nodes.

Fix #106876

Co-authored-by: Jakob Botsch Nielsen <jakob.botsch.nielsen@gmail.com>
Co-authored-by: Jeff Schwartz <jeffschw@microsoft.com>
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2024
mikelle-rogers pushed a commit to mikelle-rogers/runtime that referenced this issue Dec 10, 2024
@jakobbotsch @mikelle-rogers
JIT: Fix CndSel(AllTrue, op2, op3) -> op2 "next" node return (dotne…
7accca1 
…t#106954)

When lowering makes this transformation it should proceed lowering from
the original next node of the `CndSel`, not from `op2`. If we proceed
lowering from `op2` we will relower some nodes.

Fix dotnet#106876
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jakobbotsch jakobbotsch

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI arm-sve Work related to arm64 SVE/SVE2 support in-pr There is an active PR which will close this issue when it is merged
Projects
None yet
Milestone
9.0.0
Development

Successfully merging a pull request may close this issue.

JIT: Fix CndSel(AllTrue, op2, op3) -> op2 "next" node return jakobbotsch/runtime
2 participants
@jakobbotsch @JulieLeeMSFT