Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable embedding *.res resources via ilasm #11412

Open
jkoritzinsky opened this issue Nov 5, 2018 · 5 comments
Open

Enable embedding *.res resources via ilasm #11412

jkoritzinsky opened this issue Nov 5, 2018 · 5 comments
Labels
area-ILTools-coreclr Priority:3 Work that is nice to have
Milestone

Comments

@jkoritzinsky
Copy link
Member

As mentioned in dotnet/coreclr#20818, ilasm delegates out a step of the resource-embedding process to a process named CvtRes.exe. We don't ship CvtRes.exe with .NET Core (it's also not OSS). So, we need to come up with a plan that allows us to enable resource embedding of *.res files with ilasm on .NET Core.

@jkoritzinsky jkoritzinsky changed the title Enable resource embedding in ilasm Enable embedding *.res resources via ilasm Nov 6, 2018
@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@msftgits msftgits added this to the Future milestone Jan 31, 2020
BruceForstall added a commit that referenced this issue Jul 2, 2020
* Enable ilasm/ildasm round trip testing in new AzDO pipeline

Pipeline is `runtime-coreclr ilasm`.

Also, add an optional `IlasmRoundTripIncompatible` msbuild
property to allow disabling tests for the IlasmRoundTrip test.

* Disable tests for ilasm round-trip testing

Tracking issues:
#11412
#38515
#38506
#38507
#38508
#38529
@TIHan TIHan added the Priority:3 Work that is nice to have label Apr 24, 2023
@TIHan
Copy link
Contributor

TIHan commented Apr 24, 2023

Are there any customers blocked by this issue?

@jkoritzinsky
Copy link
Member Author

We have some tests that we can't enable while this issue is present since the lack of this feature means that App Manifests are dropped in the ilasm-ildasm round-trip tests. There are no customers that have asked for this feature specifically though.

@jkoritzinsky
Copy link
Member Author

Actually, looking at the issue reference logs above, #48046 is a customer request for this feature (it's just about the ilasm flag, not the underlying feature). One of these can be closed as a duplicate of the other.

@TIHan
Copy link
Contributor

TIHan commented Apr 24, 2023

Not sure how quickly we could add support for this, I imagine it would take some time and the only immediate gain would be enabling some of those round-trip tests.

@jkoritzinsky
Copy link
Member Author

Roslyn already has a managed port of CvtRes, so we could port their OSS port back to C++. Or I could eventually have time to finish my managed port of ILAsm and we could use the Roslyn version as-is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-ILTools-coreclr Priority:3 Work that is nice to have
Projects
None yet
Development

No branches or pull requests

3 participants