[x64[r2r] ObjectStackAllocationTests is broken after #21950 #11826
Assignees
Comments
erozenfeld
referenced
this issue
in erozenfeld/coreclr
Jan 19, 2019
AllocateSimpleClassAndCheckTypeNoHelper fails because the object is allocated on the heap in R2R mode. The reason for that is that we always use a helper for isinst in R2R mode and helper calls cause us to assume the object escapes. We don't have to use a helper in this case (even for R2R), #22086 tracks fixing that. For now the fix is not to check that the object was allocated on the stack in this test case. Fixes #22026.
erozenfeld
referenced
this issue
in dotnet/coreclr
Jan 23, 2019
AllocateSimpleClassAndCheckTypeNoHelper fails because the object is allocated on the heap in R2R mode. The reason for that is that we always use a helper for isinst in R2R mode and helper calls cause us to assume the object escapes. We don't have to use a helper in this case (even for R2R), #22086 tracks fixing that. For now the fix is not to check that the object was allocated on the stack in this test case. Fixes #22026.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The output shows:
FAILURE (AllocateSimpleClassAndCheckTypeNoHelper): unexpected allocation of 24 bytesStarted to fail afer dotnet/coreclr#21950.
CI example:.
PTAL @erozenfeld , cc @dotnet/jit-contrib
The text was updated successfully, but these errors were encountered: