Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Fix R2R failure in one of ObjectStackAllocation tests. #22088

Merged
merged 1 commit into from
Jan 23, 2019

Conversation

erozenfeld
Copy link
Member

AllocateSimpleClassAndCheckTypeNoHelper fails because
the object is allocated on the heap in R2R mode. The reason for that is
that we always use a helper for isinst in R2R mode and helper calls
cause us to assume the object escapes.

We don't have to use a helper in this case (even for R2R), #22086 tracks
fixing that.

For now the fix is not to check that the object was allocated on the stack
in this test case.

Fixes #22026.

AllocateSimpleClassAndCheckTypeNoHelper fails because
the object is allocated on the heap in R2R mode. The reason for that is
that we always use a helper for isinst in R2R mode and helper calls
cause us to assume the object escapes.

We don't have to use a helper in this case (even for R2R), #22086 tracks
fixing that.

For now the fix is not to check that the object was allocated on the stack
in this test case.

Fixes #22026.
@erozenfeld
Copy link
Member Author

@sandreenko @echesakovMSFT @dotnet/jit-contrib PTAL

@erozenfeld
Copy link
Member Author

@dotnet-bot test Windows_NT x64 Checked r2r_no_tiered_compilation
@dotnet-bot test Ubuntu x64 Checked r2r_no_tiered_compilation

@erozenfeld erozenfeld closed this Jan 22, 2019
@erozenfeld erozenfeld reopened this Jan 22, 2019
@erozenfeld
Copy link
Member Author

@dotnet-bot test OSX10.12 x64 Checked Innerloop Build and Test
@dotnet-bot test Ubuntu arm Cross Checked crossgen_comparison Build and Test
@dotnet-bot test Ubuntu x64 Checked Innerloop Build and Test (Jit - TieredCompilation=0)
@dotnet-bot test Ubuntu x64 Checked R2R Build and Test
@dotnet-bot test Ubuntu x64 Checked R2R no_tiered_compilation Build and Test
@dotnet-bot test Windows_NT x64 full_opt ryujit CoreCLR Perf Tests Correctness
@dotnet-bot test Windows_NT x64 min_opt ryujit CoreCLR Perf Tests Correctness
@dotnet-bot test Windows_NT x86 full_opt ryujit CoreCLR Perf Tests Correctness
@dotnet-bot test Windows_NT x86 min_opt ryujit CoreCLR Perf Tests Correctness

@erozenfeld erozenfeld merged commit 765a653 into dotnet:master Jan 23, 2019
@erozenfeld erozenfeld deleted the Fix22026 branch January 23, 2019 19:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[x64[r2r] ObjectStackAllocationTests is broken after #21950
3 participants