System.Security.Cryptography.OpenSsl.Tests shouldn't run on macOS

[vcsjones]

When I run the entire runtime's tests locally using:

./build.sh -rc release -s libs.tests -test

This runs the System.Security.Cryptography.OpenSsl.Tests on macOS. This is not desirable because these tests will never pass on macOS after the removal of OpenSSL compatibility from macOS.

This "works" in CI because of

runtime/src/libraries/System.Security.Cryptography.OpenSsl/tests/System.Security.Cryptography.OpenSsl.Tests.csproj

Line 5 in d521402

<IgnoreForCI Condition="'$(TargetOS)' == 'android' or '$(TargetOS)' == 'ios' or '$(TargetOS)' == 'tvos' or '$(TargetOS)' == 'osx'">true</IgnoreForCI>

But ideally these are not run locally, either. Is there a way we can exclude this project from running on any Apple platform when run locally, too?

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

[akoeplinger]

But ideally these are not run locally, either. Is there a way we can exclude this project from running on any Apple platform when run locally, too?

Yes we can add something like this to AssemblyInfo:

runtime/src/libraries/System.IO.Pipes/tests/AssemblyInfo.cs

Lines 4 to 6 in bd94b14

	using Xunit;
	[assembly: SkipOnPlatform(TestPlatforms.Browser, "System.IO.Pipes is not supported on Browser")]

That way when you run the assembly it will be a no-op.

If you want to also skip building/running it then you'll need to add it to ProjectExclusions in https://github.com/dotnet/runtime/blob/main/src/libraries/tests.proj though the (not very strictly enforced) convention is to only list projects there which should eventually be fixed (i.e. I think SkipOnPlatforms + IgnoreForCI is the right way in this case)

[vcsjones]

I don't know why it didn't occur to me those attributes would work at at assembly: level.