[SDK] _ComputePackageReferencePublish doesn't mark transitive dependencies of analyzers as _ExcludeFromPublishPackageReference

[pavelsavara]

Log

  System.Text.RegularExpressions.Tests -> D:\a\_work\1\s\artifacts\bin\System.Text.RegularExpressions.Tests\Release\net10.0\browser-wasm\publish\
D:\a\_work\1\s\src\mono\wasm\build\WasmApp.Common.targets(771,5): message WASM0060: Type System.String is not blittable: Not a ValueType [D:\a\_work\1\s\src\libraries\System.Text.RegularExpressions\tests\FunctionalTests\System.Text.RegularExpressions.Tests.csproj::TargetFramework=net10.0]
D:\a\_work\1\s\src\mono\wasm\build\WasmApp.Common.targets(771,5): message WASM0062: Type NuGet.Packaging.Signing.CRYPT_ALGORITHM_IDENTIFIER is not blittable: Field pszObjId is not blittable [D:\a\_work\1\s\src\libraries\System.Text.RegularExpressions\tests\FunctionalTests\System.Text.RegularExpressions.Tests.csproj::TargetFramework=net10.0]
D:\a\_work\1\s\src\mono\wasm\build\WasmApp.Common.targets(771,5): message WASM0062: Type NuGet.Packaging.Signing.CMSG_SIGNER_ENCODE_INFO is not blittable: Field HashAlgorithm is not blittable [D:\a\_work\1\s\src\libraries\System.Text.RegularExpressions\tests\FunctionalTests\System.Text.RegularExpressions.Tests.csproj::TargetFramework=net10.0]
##[error]src\mono\wasm\build\WasmApp.Common.targets(771,5): error WASM0001: (NETCORE_ENGINEERING_TELEMETRY=Build) Could not get pinvoke, or callbacks for method 'NuGet.Packaging.Signing.NativeMethods::CryptMsgCountersign' because 'System.NotSupportedException: Unsupported parameter type in method 'NuGet.Packaging.Signing.NativeMethods.CryptMsgCountersign'
   at PInvokeCollector.<CollectPInvokes>g__CollectPInvokesForMethod|6_0(MethodInfo method, <>c__DisplayClass6_0&) in /_/src/tasks/WasmAppBuilder/PInvokeCollector.cs:line 113
   at PInvokeCollector.CollectPInvokes(List`1 pinvokes, List`1 callbacks, HashSet`1 signatures, Type type) in /_/src/tasks/WasmAppBuilder/PInvokeCollector.cs:line 75'
D:\a\_work\1\s\src\mono\wasm\build\WasmApp.Common.targets(771,5): error WASM0001: Could not get pinvoke, or callbacks for method 'NuGet.Packaging.Signing.NativeMethods::CryptMsgCountersign' because 'System.NotSupportedException: Unsupported parameter type in method 'NuGet.Packaging.Signing.NativeMethods.CryptMsgCountersign' [D:\a\_work\1\s\src\libraries\System.Text.RegularExpressions\tests\FunctionalTests\System.Text.RegularExpressions.Tests.csproj::TargetFramework=net10.0]
D:\a\_work\1\s\src\mono\wasm\build\WasmApp.Common.targets(771,5): error WASM0001:    at PInvokeCollector.<CollectPInvokes>g__CollectPInvokesForMethod|6_0(MethodInfo method, <>c__DisplayClass6_0&) in /_/src/tasks/WasmAppBuilder/PInvokeCollector.cs:line 113 [D:\a\_work\1\s\src\libraries\System.Text.RegularExpressions\tests\FunctionalTests\System.Text.RegularExpressions.Tests.csproj::TargetFramework=net10.0]
D:\a\_work\1\s\src\mono\wasm\build\WasmApp.Common.targets(771,5): error WASM0001:    at PInvokeCollector.CollectPInvokes(List`1 pinvokes, List`1 callbacks, HashSet`1 signatures, Type type) in /_/src/tasks/WasmAppBuilder/PInvokeCollector.cs:line 75' [D:\a\_work\1\s\src\libraries\System.Text.RegularExpressions\tests\FunctionalTests\System.Text.RegularExpressions.Tests.csproj::TargetFramework=net10.0]

Build Information

Build: https://dev.azure.com/dnceng-public/public/_build/results?buildId=1138190
Build error leg or test failing:

Error Message

{
  "ErrorMessage": ["Could not get pinvoke, or callbacks for method", "NuGet.Packaging.Signing.NativeMethods::CryptMsgCountersign"],
  "BuildRetry": false,
  "ExcludeConsoleLog": false
}

Known issue validation

Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=1138190
Error message validated: [Could not get pinvoke, or callbacks for method NuGet.Packaging.Signing.NativeMethods::CryptMsgCountersign]
Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 9/3/2025 1:40:28 PM UTC

Report

Build	Definition	Step Name	Console log	Pull Request
1138190	dotnet/runtime	Build product	Log	#119307

Summary

24-Hour Hit Count	7-Day Hit Count	1-Month Count
1	1	1

[dotnet-policy-service]

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

[pavelsavara]

Why we are trying to reference NuGet.Client on WASM ?

https://github.com/NuGet/NuGet.Client/blob/546b0dc025190ab9cf744ad4be544c23042688c1/src/NuGet.Core/NuGet.Packaging/Signing/Cms/NativeMethods.cs#L39-L44

[pavelsavara]

Also, we probably should not collect PInvokes before IL trimming.

[pavelsavara]

These are wrong package references

NuGet.Common
NuGet.Configuration
NuGet.Frameworks
NuGet.Packaging
NuGet.Protocol
NuGet.Resolver
NuGet.Versioning

These are source package references

Microsoft.Net.Compilers.Toolset
xunit.core
xunit.analyzers
Microsoft.DotNet.XUnitAssert
Microsoft.DotNet.XUnitExtensions
Microsoft.DotNet.RemoteExecutor
Newtonsoft.Json
Microsoft.CodeAnalysis.CSharp.Workspaces
Microsoft.CodeAnalysis.CSharp.CodeFix.Testing
Microsoft.CodeAnalysis
System.Text.RegularExpressions.TestData
Microsoft.DotNet.CodeAnalysis
Microsoft.CodeAnalysis.NetAnalyzers
Microsoft.CodeAnalysis.CSharp.CodeStyle
Microsoft.CodeAnalysis.Analyzers
StyleCop.Analyzers
Microsoft.DiaSymReader.Pdb2Pdb
Microsoft.DotNet.XUnitConsoleRunner
Microsoft.DotNet.Build.Tasks.TargetFramework

[pavelsavara]

Microsoft.CodeAnalysis.CSharp.CodeFix.Testing -> Microsoft.CodeAnalysis.Analyzer.Testing -> NuGet.Common

[pavelsavara]

This is by design, there are testes like RegexGeneratorOutputTests.cs which use generators at runtime.