[wasm][coreclr] bc.GenericVirtualMethod<string> failing in the interpreter test

[radekdoulik]

It fails with

...
bc.GenericVirtualMethod<string>
ASSERT FAILED
        Expression: !"Precode::GetPrecodeFromEntryPoint is not supported with Portable EntryPoints"
        Location:   line 170 in /Users/rodo/git/runtime-main/src/coreclr/vm/precode_portable.cpp
        Function:   GetPrecodeFromEntryPoint
        Process:    42
Frame (InterpreterFrame): 0x4fecac
   0) InterpreterTest::TestVirtual, IR_00e3
   1) InterpreterTest::RunInterpreterTests, IR_04ee
   2) InterpreterTest::Main, IR_0029

the failing part

        Console.WriteLine("bc.GenericVirtualMethod<string>");
        retType = bc.GenericVirtualMethod<string>(out isBase);
        if (retType != typeof(string) || isBase)
            return false;

Also itest.GenericVirtualMethod<string> is failing the same way.

[dotnet-policy-service]

Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara
See info in area-owners.md if you want to be subscribed.

[dotnet-policy-service]

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

[radekdoulik]

What I know so far:

We are reaching this because the method desc is instantiating stub. (IsInstantiatingStub() returns true).

We have FEATURE_INSTANTIATINGSTUB_AS_IL enabled.

We get to the assert, because we end up with HasPrecode() flas set.

[radekdoulik]

I have closed the #120467 as Aaron is going to do larger clean-up which will address this.

[AaronRobinsonMSFT]

@radekdoulik See #120583 for related changes to this. Once that PR is merged in the following stack begins to fail. The issue here appears the associated Instantiation for method M<T> below is bogus.

Set the following environment variables to help:

  "DOTNET_InterpDump": "Main",
  "DOTNET_BreakOnClassBuild": "C"

using System;
using System.Diagnostics;
using System.Runtime.CompilerServices;

interface IInterface
{
    void M<T>();
}

class C : IInterface
{
    public void M<T>()
    {
        Console.WriteLine(typeof(T).ToString());
    }
}

class Program
{
    public static void Main()
    {
        Console.WriteLine("Hello World!");
        IInterface obj = new C(); // Fails during compile on WASM.
        obj.M<int>();
        obj.M<string>();
    }
}

Dictionary::EntryAddr(unsigned int) (...\src\coreclr\vm\genericdict.h:190)
Dictionary::GetInstantiation() (...\src\coreclr\vm\genericdict.h:198)
InstantiatedMethodDesc::IMD_GetMethodInstantiation() (...\src\coreclr\vm\method.hpp:3623)
MethodDesc::GetMethodInstantiation() const (...\src\coreclr\vm\method.hpp:3877)
MethodDesc::LoadConstraintsForTypicalMethodDefinition(int*, int*, ClassLoadLevel) (...\src\coreclr\vm\genmeth.cpp:1580)
MethodTable::DoFullyLoad(Generics::RecursionGraph*, ClassLoadLevel, CUnorderedArray<TypeHandle, 40>*, int*, InstantiationContext const*) (...\src\coreclr\vm\methodtable.cpp:4609)
MethodTable::DoFullyLoad(Generics::RecursionGraph*, ClassLoadLevel, CUnorderedArray<TypeHandle, 40>*, int*, InstantiationContext const*) (...\src\coreclr\vm\methodtable.cpp:4464)
TypeHandle::DoFullyLoad(Generics::RecursionGraph*, ClassLoadLevel, CUnorderedArray<TypeHandle, 40>*, int*, InstantiationContext const*) (...\src\coreclr\vm\typehandle.cpp:1164)
PushFinalLevels(TypeHandle, ClassLoadLevel, InstantiationContext const*) (...\src\coreclr\vm\clsload.cpp:2989)
ClassLoader::LoadTypeHandleForTypeKey(TypeKey const*, TypeHandle, ClassLoadLevel, InstantiationContext const*) (...\src\coreclr\vm\clsload.cpp:3056)
ClassLoader::LoadTypeDefThrowing(Module*, unsigned int, ClassLoader::NotFoundAction, ClassLoader::PermitUninstantiatedFlag, unsigned int, ClassLoadLevel, Instantiation*) (...\src\coreclr\vm\clsload.cpp:1968)
MemberLoader::GetMethodDescFromMethodDef(Module*, unsigned int, int, ClassLoadLevel) (...\src\coreclr\vm\memberload.cpp:604)
CEEInfo::resolveToken(CORINFO_RESOLVED_TOKEN*) (...\src\coreclr\vm\jitinterface.cpp:1004)
InterpCompiler::ResolveToken(unsigned int, CorInfoTokenKind, CORINFO_RESOLVED_TOKEN*) (...\src\coreclr\interpreter\compiler.cpp:3328)
InterpCompiler::EmitCall(CORINFO_RESOLVED_TOKEN*, bool, bool, bool, bool) (...\src\coreclr\interpreter\compiler.cpp:3757)
InterpCompiler::GenerateCode(CORINFO_METHOD_INFO*) (...\src\coreclr\interpreter\compiler.cpp:6250)
InterpCompiler::CompileMethod() (...\src\coreclr\interpreter\compiler.cpp:1700)
CILInterp::compileMethod(ICorJitInfo*, CORINFO_METHOD_INFO*, unsigned int, unsigned char**, unsigned int*) (...\src\coreclr\interpreter\eeinterp.cpp:110)
invokeCompileMethod(EECodeGenManager*, CEECodeGenInfo*, unsigned char**, unsigned int*, NativeCodeVersion) (...\src\coreclr\vm\jitinterface.cpp:12912)
UnsafeJitFunctionWorker(EECodeGenManager*, CEECodeGenInfo*, NativeCodeVersion, unsigned int*) (...\src\coreclr\vm\jitinterface.cpp:13134)
UnsafeJitFunction(PrepareCodeConfig*, COR_ILMETHOD_DECODER*, bool*, bool*, unsigned int*) (...\src\coreclr\vm\jitinterface.cpp:13402)
MethodDesc::JitCompileCodeLocked(PrepareCodeConfig*, COR_ILMETHOD_DECODER*, ListLockEntryBase<NativeCodeVersion>*, unsigned int*, bool*) (...\src\coreclr\vm\prestub.cpp:908)
MethodDesc::JitCompileCodeLockedEventWrapper(PrepareCodeConfig*, ListLockEntryBase<NativeCodeVersion>*) (...\src\coreclr\vm\prestub.cpp:802)
MethodDesc::JitCompileCode(PrepareCodeConfig*) (...\src\coreclr\vm\prestub.cpp:674)
MethodDesc::PrepareILBasedCode(PrepareCodeConfig*) (...\src\coreclr\vm\prestub.cpp:404)
MethodDesc::PrepareCode(PrepareCodeConfig*) (...\src\coreclr\vm\prestub.cpp:314)
MethodDesc::PrepareInitialCode(CallerGCMode) (...\src\coreclr\vm\prestub.cpp:304)
MethodDesc::DoPrestub(MethodTable*, CallerGCMode) (...\src\coreclr\vm\prestub.cpp:2298)
::CallDescrWorkerInternal(CallDescrData *) (...\src\coreclr\vm\wasm\calldescrworkerwasm.cpp:16)
CallDescrWorker(CallDescrData*) (...\src\coreclr\vm\callhelpers.cpp:106)
CallDescrWorkerWithHandler(CallDescrData*, int) (...\src\coreclr\vm\callhelpers.cpp:59)
MethodDescCallSite::CallTargetWorker(unsigned long long const*, unsigned long long*, int) (...\src\coreclr\vm\callhelpers.cpp:549)
MethodDescCallSite::Call(unsigned long long const*) (...\src\coreclr\vm\callhelpers.h:443)
RunMainInternal(Param*) (...\src\coreclr\vm\assembly.cpp:1210)
RunMain(MethodDesc*, short, int*, REF<PtrArray>*)::$_1::operator()(Param*) const::'lambda'(Param*)::operator()(Param*) const (...\src\coreclr\vm\assembly.cpp:1279)
RunMain(MethodDesc*, short, int*, REF<PtrArray>*)::$_1::operator()(Param*) const (...\src\coreclr\vm\assembly.cpp:1281)
RunMain(MethodDesc*, short, int*, REF<PtrArray>*) (...\src\coreclr\vm\assembly.cpp:1281)
Assembly::ExecuteMainMethod(REF<PtrArray>*, int) (...\src\coreclr\vm\assembly.cpp:1407)
CorHost2::ExecuteAssembly(unsigned int, char16_t const*, int, char16_t const**, unsigned int*) (...\src\coreclr\vm\corhost.cpp:349)
::coreclr_execute_assembly(void *, unsigned int, int, const char **, const char *, unsigned int *) (...\src\coreclr\dlls\mscoree\exports.cpp:491)
run(configuration const&) (...\src\coreclr\hosts\corerun\corerun.cpp:524)
__main_argc_argv (...\src\coreclr\hosts\corerun\corerun.cpp:738)
<anonymous> (...\artifacts\bin\coreclr\browser.wasm.Debug\corerun.js:672)
global.callMain (...\artifacts\bin\coreclr\browser.wasm.Debug\corerun.js:8775)
global.doRun (...\artifacts\bin\coreclr\browser.wasm.Debug\corerun.js:8825)
global.run (...\artifacts\bin\coreclr\browser.wasm.Debug\corerun.js:8840)
global.runCaller (...\artifacts\bin\coreclr\browser.wasm.Debug\corerun.js:8752)
global.removeRunDependency (...\artifacts\bin\coreclr\browser.wasm.Debug\corerun.js:596)
global.receiveInstance (...\artifacts\bin\coreclr\browser.wasm.Debug\corerun.js:793)
global.receiveInstantiationResult (...\artifacts\bin\coreclr\browser.wasm.Debug\corerun.js:811)
Promise.then (Unknown Source:0)
instantiateArrayBuffer (...\artifacts\bin\coreclr\browser.wasm.Debug\corerun.js:720)
instantiateAsync (...\artifacts\bin\coreclr\browser.wasm.Debug\corerun.js:762)
createWasm (...\artifacts\bin\coreclr\browser.wasm.Debug\corerun.js:830)
<anonymous> (...\artifacts\bin\coreclr\browser.wasm.Debug\corerun.js:8375)
<anonymous> (<node_internals>/internal/modules/cjs/loader:1706)
<anonymous> (<node_internals>/internal/modules/cjs/loader:1839)
<anonymous> (<node_internals>/internal/modules/cjs/loader:1441)
<anonymous> (<node_internals>/internal/modules/cjs/loader:1263)
traceSync (<node_internals>/diagnostics_channel:322)
wrapModuleLoad (<node_internals>/internal/modules/cjs/loader:237)
executeUserEntryPoint (<node_internals>/internal/modules/run_main:171)
<anonymous> (<node_internals>/internal/main/run_main_module:36)