-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove private CoreFx and CoreClr transport packages #126
Comments
Does someone know of other consumers of these two transport packages? |
The sharedfx SDK requires crossgen, but I think we could change that so the builder selects either:
This is something downstream repos depend on, not the sharedfx SDK itself. WindowsDesktop depends on compat packages, ASP.NET Core brings in some more, some other downstreams like IoT may depend on others.
What does this help with? The packages still need to be published to a feed so the metapackage can reference them, right? The repo gains a dependency on a private/transport metapackage, and then needs to manually filter out which sub-packages it actually needs, rather than letting NuGet do it. |
I don't understand how we could use that package? We will still produce OOB packages. Actually this package was only for testing purposes, and I think it should go away once Mono is part of the consolidated repo. |
That package is needed by the performance repo as well. |
Ah, that's correct. |
As we are switching away from package dependencies for CoreClr and CoreFx we should discuss remaining consumers of the private transport packages:
I quickly talked with @dagood about this. The SharedFramework.Sdk requires crossgen from the CoreClr package and some OOB packages from the CoreFx one. We should probably package crossgen up and add it to BAR. For the OOB ones we already have a package which references all the OOB packages:
Microsoft.Private.CoreFx.OOB
which could probably be used instead.cc @dotnet/runtime-infrastructure
The text was updated successfully, but these errors were encountered: