Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove private CoreFx and CoreClr transport packages #126

Closed
ViktorHofer opened this issue Nov 19, 2019 · 5 comments · Fixed by #5523
Closed

Remove private CoreFx and CoreClr transport packages #126

ViktorHofer opened this issue Nov 19, 2019 · 5 comments · Fixed by #5523

Comments

@ViktorHofer
Copy link
Member

As we are switching away from package dependencies for CoreClr and CoreFx we should discuss remaining consumers of the private transport packages:

I quickly talked with @dagood about this. The SharedFramework.Sdk requires crossgen from the CoreClr package and some OOB packages from the CoreFx one. We should probably package crossgen up and add it to BAR. For the OOB ones we already have a package which references all the OOB packages: Microsoft.Private.CoreFx.OOB which could probably be used instead.

cc @dotnet/runtime-infrastructure

@ViktorHofer ViktorHofer added this to the 5.0 milestone Nov 19, 2019
@ViktorHofer
Copy link
Member Author

Does someone know of other consumers of these two transport packages?

@dagood
Copy link
Member

dagood commented Nov 19, 2019

The SharedFramework.Sdk requires crossgen from the CoreClr package

The sharedfx SDK requires crossgen, but I think we could change that so the builder selects either:

  • The NETCoreApp Runtime pack (to use in WindowsDesktop, ASP.NET Core, and Core-SDK)
  • The live-built crossgen (to use in dotnet/runtime)

and some OOB packages from the CoreFx one

This is something downstream repos depend on, not the sharedfx SDK itself. WindowsDesktop depends on compat packages, ASP.NET Core brings in some more, some other downstreams like IoT may depend on others.

For the OOB ones we already have a package which references all the OOB packages: Microsoft.Private.CoreFx.OOB which could probably be used instead.

What does this help with? The packages still need to be published to a feed so the metapackage can reference them, right? The repo gains a dependency on a private/transport metapackage, and then needs to manually filter out which sub-packages it actually needs, rather than letting NuGet do it.

@safern
Copy link
Member

safern commented Nov 19, 2019

For the OOB ones we already have a package which references all the OOB packages: Microsoft.Private.CoreFx.OOB which could probably be used instead.

I don't understand how we could use that package? We will still produce OOB packages. Actually this package was only for testing purposes, and I think it should go away once Mono is part of the consolidated repo.

@ViktorHofer
Copy link
Member Author

That package is needed by the performance repo as well.

@safern
Copy link
Member

safern commented Nov 19, 2019

That package is needed by the performance repo as well.

Ah, that's correct.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants