Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeIntrinsics_il test build fails #1265

Closed
BruceForstall opened this issue Jan 3, 2020 · 3 comments · Fixed by #1271
Closed

TypeIntrinsics_il test build fails #1265

BruceForstall opened this issue Jan 3, 2020 · 3 comments · Fixed by #1271
Assignees
@EgorBo
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI test-bug Problem in test source code (most likely) untriaged New issue has not been triaged by the area owner

Comments

@BruceForstall
Copy link
Member

It looks like the build of the TypeIntrinsics_il test (added in #1157) fails:

TypeIntrinsics_il.il(20): error : syntax error at token '&' in:     ldtoken    [System.Runtime]System.String& [F:\gh\runtime\src\coreclr\tests\src\JIT\Intrinsics\TypeIntrinsics_il.ilproj]

The test was added as a pri-1 test, but I don't see evidence that the PR triggered Pri-1 (outerloop) testing (it hasn't been in good shape recently anyway).
@BruceForstall BruceForstall added test-bug Problem in test source code (most likely) area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Jan 3, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Jan 3, 2020
@BruceForstall
Copy link
Member Author

@EgorBo
cc @jkotas @AndyAyersMS

@EgorBo EgorBo mentioned this issue Jan 3, 2020
Merged
@janvorli
Copy link
Member

janvorli commented Jan 6, 2020

Also, the test compilation prints a warning:
TypeIntrinsics_il.il(20,0): warning : Reference to undeclared extern assembly 'System.Runtime'. Attempting autodetect

@EgorBo
Copy link
Member

EgorBo commented Jan 7, 2020

@janvorli fixed in #1271 thanks

@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@EgorBo EgorBo

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI test-bug Problem in test source code (most likely) untriaged New issue has not been triaged by the area owner
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix TypeIntrinsics_il tests EgorBo/runtime-1
4 participants
@EgorBo @janvorli @BruceForstall @Dotnet-GitSync-Bot