Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TypeIntrinsics_il tests #1271

Merged
merged 3 commits into from
Jan 7, 2020
Merged

Fix TypeIntrinsics_il tests #1271

merged 3 commits into from
Jan 7, 2020

Conversation

EgorBo
Copy link
Member

@EgorBo EgorBo commented Jan 3, 2020 •
edited
Loading

Fixes #1265
Sorry, didn't know what <CLRTestPriority>1</CLRTestPriority> is for. Also it seems I can use & only for string and object (?).

@MichalStrehovsky
Copy link
Member

Also it seems I can use & only for string and object (?).

I think you just need to prefix this with class or valuetype (so ldtoken [System.Runtime]System.Int16& turns into ldtoken valuetype [System.Runtime]System.Int16&. The object and string are keywords and ILAsm knows what they are.

@EgorBo
Copy link
Member Author

EgorBo commented Jan 7, 2020

@MichalStrehovsky good to know, thanks! Fixed.

@EgorBo EgorBo mentioned this pull request Jan 7, 2020
Closed
@jkotas jkotas merged commit f7c4294 into dotnet:master Jan 7, 2020
@EgorBo EgorBo deleted the fix-typeintrin-test branch May 25, 2020 11:57
@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MichalStrehovsky MichalStrehovsky MichalStrehovsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeIntrinsics_il test build fails
3 participants
@EgorBo @MichalStrehovsky @jkotas